Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2594973002: Revert of Refactor webrtc/modules/video_processing for GN check (Closed)

Created:
4 years ago by mbonadei
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactor webrtc/modules/video_processing for GN check (patchset #3 id:40001 of https://codereview.webrtc.org/2595543002/ ) Reason for revert: This CL broke some buildbots. I will investigate it later. Original issue's description: > Refactor webrtc/modules/video_processing for GN check > > This moves some GN check configurations out of .gn to individual > targets. > > The now checked target is: > "//webrtc/modules/video_processing/*" > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2595543002 > Cr-Commit-Position: refs/heads/master@{#15732} > Committed: https://chromium.googlesource.com/external/webrtc/+/00a810b844b2393b64f7e36ce1524dd9e3dccb4b TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2594973002 Cr-Commit-Position: refs/heads/master@{#15733} Committed: https://chromium.googlesource.com/external/webrtc/+/d39e16ac300d7947d22b953898aaef073e553ad3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Refactor webrtc/modules/video_processing for GN check
4 years ago (2016-12-21 10:18:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2594973002/1
4 years ago (2016-12-21 10:18:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d39e16ac300d7947d22b953898aaef073e553ad3
4 years ago (2016-12-21 10:18:58 UTC) #6
kjellander_webrtc
4 years ago (2016-12-21 12:47:36 UTC) #7
Message was sent while issue was closed.
lgtm

I'm curious what it broke. It's always a good idea to provide a link and/or
error log message in the Revert CL, otherwise it'll be hard to track down the
failure when fixing the problem (which might not happen until weeks later).

Powered by Google App Engine
This is Rietveld 408576698