RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ

RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ

Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.

BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2594553003
Cr-Commit-Position: refs/heads/master@{#15738}
Committed: https://chromium.googlesource.com/external/webrtc/+/23368e1aef2e8828ca0ac07405c1debd14b0c77d

[hbos, 2016-12-20 16:46:40]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 16:46:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-12-20 16:48:04]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[hbos, 2016-12-20 16:48:04]

Please take a look, deadbeef.

[commit-bot: I haz the power, 2016-12-20 17:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 17:49:23]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2016-12-20 19:49:49]

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
File webrtc/api/rtcstatscollector_unittest.cc (right):

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
webrtc/api/rtcstatscollector_unittest.cc:641:
ASSERT(report->Get(expected_local_certificate.id()));
Should this use ASSERT_TRUE, so it's a gtest assert?

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
webrtc/api/rtcstatscollector_unittest.cc:644: RTCCertificateStats>());
Each of these blocks of code is effectively the same as
ExpectReportContainsCertificateInfo, but uses EXPECT_EQ. So I think it would
make more sense to keep ExpectReportContainsCertificateInfo around and just
change it to use EXPECT_EQ.

[hbos, 2016-12-21 09:57:22]

Description was changed from

==========
RTCStatsCollectorTest: Remove ExpectReportContainsCertificateInfo.

Remove ExpectReportContainsCertificateInfo in favor of EXPECT_EQ checks
of RTCCertificateStats objects.

BUG=chromium:627816
==========

to

==========
RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ

Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.

BUG=chromium:627816
==========

[hbos, 2016-12-21 09:58:43]

Patchset #2 (id:20001) has been deleted

[hbos, 2016-12-21 09:59:11]

PTAL deadbeef.

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
File webrtc/api/rtcstatscollector_unittest.cc (right):

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
webrtc/api/rtcstatscollector_unittest.cc:641:
ASSERT(report->Get(expected_local_certificate.id()));
On 2016/12/20 19:49:49, Taylor Brandstetter wrote:
> Should this use ASSERT_TRUE, so it's a gtest assert?

Ah, yes!

https://codereview.webrtc.org/2594553003/diff/1/webrtc/api/rtcstatscollector_...
webrtc/api/rtcstatscollector_unittest.cc:644: RTCCertificateStats>());
On 2016/12/20 19:49:49, Taylor Brandstetter wrote:
> Each of these blocks of code is effectively the same as
> ExpectReportContainsCertificateInfo, but uses EXPECT_EQ. So I think it would
> make more sense to keep ExpectReportContainsCertificateInfo around and just
> change it to use EXPECT_EQ.

Yeah that makes sense :) Done.

[Taylor Brandstetter, 2016-12-21 10:50:03]

lgtm

[hbos, 2016-12-21 12:03:58]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-12-21 12:03:59]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2594553003/#ps60001 (title:
"Rebase with master")

[commit-bot: I haz the power, 2016-12-21 12:04:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-21 12:29:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482321838952720,
"parent_rev": "c42ba32877d3b520f96dff5720f83f5230580fe2", "commit_rev":
"23368e1aef2e8828ca0ac07405c1debd14b0c77d"}

[commit-bot: I haz the power, 2016-12-21 12:29:20]

Description was changed from

==========
RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ

Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.

BUG=chromium:627816
==========

to

==========
RTCStatsCollectorTest: ExpectReportContainsCertificateInfo /w EXPECT_EQ

Modify ExpectReportContainsCertificateInfo to use EXPECT_EQ checks of
RTCCertificateStats objects.

BUG=chromium:627816

Review-Url: https://codereview.webrtc.org/2594553003
Cr-Commit-Position: refs/heads/master@{#15738}
Committed:
https://chromium.googlesource.com/external/webrtc/+/23368e1aef2e8828ca0ac0740...
==========

[commit-bot: I haz the power, 2016-12-21 12:29:21]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/23368e1aef2e8828ca0ac0740...