Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2594523003: Refactor webrtc/modules/pacing for GN check (Closed)

Created:
4 years ago by mbonadei
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/pacing for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/pacing/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2594523003 Cr-Commit-Position: refs/heads/master@{#15729} Committed: https://chromium.googlesource.com/external/webrtc/+/2a495ca2971282bda060d603e95a498dd9839689

Patch Set 1 #

Patch Set 2 : Refactor webrtc/modules/pacing for GN check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mbonadei
4 years ago (2016-12-20 16:29:33 UTC) #2
kjellander_webrtc
lgtm I added BUG=webrtc:6828 NOTRY=True
4 years ago (2016-12-20 18:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2594523003/1
4 years ago (2016-12-21 07:45:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11651)
4 years ago (2016-12-21 07:48:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2594523003/20001
4 years ago (2016-12-21 08:25:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-21 08:27:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2a495ca2971282bda060d603e...

Powered by Google App Engine
This is Rietveld 408576698