Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2594343002: Revert of Make P2PTransportChannel inherit from IceTransportInternal. (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make P2PTransportChannel inherit from IceTransportInternal. (patchset #3 id:80001 of https://codereview.webrtc.org/2590063002/ ) Reason for revert: Breaks Chromium WebRTC FYI bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/12337 The error was masked by another breaking change that was committer earlier. This is the first build showing the error. Original issue's description: > Make P2PTransportChannel inherit from IceTransportInternal. > > Make P2PTransportChannel inherit from IceTransportInternal instead of > TransportChannelImpl and TransportChannel, so that the DTLS-related methods can > be separated from P2PTransportChannel. > > BUG=none > > Review-Url: https://codereview.webrtc.org/2590063002 > Cr-Commit-Position: refs/heads/master@{#15743} > Committed: https://chromium.googlesource.com/external/webrtc/+/12749d89d9f004cc1961aa6ece6600cc14c57ac5 TBR=deadbeef@webrtc.org,zhihuang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.webrtc.org/2594343002 Cr-Commit-Position: refs/heads/master@{#15751} Committed: https://chromium.googlesource.com/external/webrtc/+/c37ad499dac38d992a09e3b3565a366b283a2521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -426 lines) Patch
M webrtc/p2p/base/dtlstransportchannel.h View 7 chunks +17 lines, -16 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 6 chunks +13 lines, -235 lines 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 4 chunks +5 lines, -18 lines 0 comments Download
M webrtc/p2p/base/jseptransport.h View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 8 chunks +58 lines, -29 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 7 chunks +23 lines, -50 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 21 chunks +28 lines, -31 lines 0 comments Download
M webrtc/p2p/base/packettransportinterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportchannel.h View 3 chunks +17 lines, -10 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M webrtc/p2p/base/udptransportchannel.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of Make P2PTransportChannel inherit from IceTransportInternal.
4 years ago (2016-12-22 07:51:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2594343002/1
4 years ago (2016-12-22 07:51:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c37ad499dac38d992a09e3b3565a366b283a2521
4 years ago (2016-12-22 07:52:04 UTC) #6
kjellander_webrtc
4 years ago (2016-12-22 09:15:14 UTC) #7
Message was sent while issue was closed.
On 2016/12/22 07:52:04, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/c37ad499dac38d992a09e3b35...

Follow-up: This greened up all the builds, so the revert was correct.
For relanding, please make changes that aren't breaking the API + run Chromium
trybots for the WebRTC CL as mentioned at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots

Powered by Google App Engine
This is Rietveld 408576698