Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2593963003: Revert "Revert of Parse FlexFEC RTP headers in Call and add integration with BWE. (patchset #17 id:… (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Parse FlexFEC RTP headers in Call and add integration with BWE. (patchset #17 id:460001 of https://codereview.webrtc.org/2553863003/ )" Problem fixed: RTP header extensions were not properly set in tests. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2593963003 Cr-Commit-Position: refs/heads/master@{#15741} Committed: https://chromium.googlesource.com/external/webrtc/+/b29e652b10f1bf9343a90308d29acdc09299cbca

Patch Set 1 : Revert of revert. #

Patch Set 2 : Enable RTP header extensions for FlexFEC in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -166 lines) Patch
M webrtc/call/call.cc View 12 chunks +102 lines, -19 lines 0 comments Download
M webrtc/call/flexfec_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/flexfec_receive_stream_impl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_impl.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_unittest.cc View 4 chunks +18 lines, -23 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc View 6 chunks +22 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc View 27 chunks +52 lines, -68 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/call_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
brandtr
Simple fix, and local perf runs look convincing: the ULPFEC and FlexFEC results are much ...
4 years ago (2016-12-21 13:55:18 UTC) #5
stefan-webrtc
lgtm
4 years ago (2016-12-21 13:57:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593963003/20001
4 years ago (2016-12-21 14:07:18 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-21 14:37:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b29e652b10f1bf9343a90308d...

Powered by Google App Engine
This is Rietveld 408576698