Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2593693002: Refactor webrtc/modules/media_file for GN check (Closed)

Created:
4 years ago by mbonadei
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/media_file for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/media_file/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2593693002 Cr-Commit-Position: refs/heads/master@{#15726} Committed: https://chromium.googlesource.com/external/webrtc/+/ba96730bd81c6b0e367fa592c32da7ef481ab33d

Patch Set 1 #

Patch Set 2 : Refactor webrtc/modules/media_file for GN check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mbonadei
4 years ago (2016-12-20 16:47:38 UTC) #2
kjellander_webrtc
lgtm, I added NOTRY=True for you and triggered a few trybots just to be sure. ...
4 years ago (2016-12-20 18:39:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593693002/1
4 years ago (2016-12-21 07:50:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11653)
4 years ago (2016-12-21 07:53:00 UTC) #8
kjellander_webrtc
On 2016/12/21 07:53:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-21 08:10:37 UTC) #9
mbonadei
On 2016/12/21 08:10:37, kjellander_webrtc wrote: > On 2016/12/21 07:53:00, commit-bot: I haz the power wrote: ...
4 years ago (2016-12-21 08:19:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593693002/20001
4 years ago (2016-12-21 08:19:17 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 08:20:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ba96730bd81c6b0e367fa592c...

Powered by Google App Engine
This is Rietveld 408576698