RTCStatsReport::AddStats DCHECKs that the ID is unique.

RTCStatsReport::AddStats DCHECKs that the ID is unique.

Previously it was allowed to call AddStats with stats of the same ID
multiple times.

This revealed a few things:
- Local and remote streams can have the same label.
  RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
  remote in a loopback), so we skip creating RTCCertificateStats for the
  same certificate multiple times

BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2593503003
Cr-Commit-Position: refs/heads/master@{#15730}
Committed: https://chromium.googlesource.com/external/webrtc/+/02d2a92d92d05c3014d779efd5c03e0822b7dbe7

[hbos, 2016-12-20 15:48:00]

Patchset #1 (id:1) has been deleted

[hbos, 2016-12-20 15:52:17]

Description was changed from

==========
RTCStatsReport::AddStats DCHECKs that the ID is unique.

This revealed that local and remote streams can have the same label,
updated RTCMediaStreamStats's ID to include "local"/"remote".

This also revealed that the same certificate can show up multiple times
(again for local and remote side) in the integration test, an
if-statement prevents creating a stats object that was previously
discarded anyway (and which should contain the same information).

BUG=chromium:627816
==========

to

==========
RTCStatsReport::AddStats DCHECKs that the ID is unique.

Previously it was allowed to call AddStats with stats of the same ID
multiple times.

This revealed a few things:
- Local and remote streams can have the same label.
  RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
  remote in a loopback), so we skip creating RTCCertificateStats for the
  same certificate multiple times

BUG=chromium:627816
==========

[hbos, 2016-12-20 15:52:23]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:52:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-12-20 15:52:50]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, hta@webrtc.org

[hbos, 2016-12-20 15:52:50]

Please take a look, hta and deadbeef.

[commit-bot: I haz the power, 2016-12-20 16:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 16:32:27]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2016-12-20 19:04:16]

lgtm

[hbos, 2016-12-21 09:27:23]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-12-21 09:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-21 09:29:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482312443987710,
"parent_rev": "2a495ca2971282bda060d603e95a498dd9839689", "commit_rev":
"02d2a92d92d05c3014d779efd5c03e0822b7dbe7"}

[commit-bot: I haz the power, 2016-12-21 09:29:08]

Description was changed from

==========
RTCStatsReport::AddStats DCHECKs that the ID is unique.

Previously it was allowed to call AddStats with stats of the same ID
multiple times.

This revealed a few things:
- Local and remote streams can have the same label.
  RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
  remote in a loopback), so we skip creating RTCCertificateStats for the
  same certificate multiple times

BUG=chromium:627816
==========

to

==========
RTCStatsReport::AddStats DCHECKs that the ID is unique.

Previously it was allowed to call AddStats with stats of the same ID
multiple times.

This revealed a few things:
- Local and remote streams can have the same label.
  RTCMediaStreamStats's ID is updated to include "local"/"remote".
- The same certificate can show up multiple times (e.g. for local and
  remote in a loopback), so we skip creating RTCCertificateStats for the
  same certificate multiple times

BUG=chromium:627816

Review-Url: https://codereview.webrtc.org/2593503003
Cr-Commit-Position: refs/heads/master@{#15730}
Committed:
https://chromium.googlesource.com/external/webrtc/+/02d2a92d92d05c3014d779efd...
==========

[commit-bot: I haz the power, 2016-12-21 09:29:08]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/02d2a92d92d05c3014d779efd...