Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2593313002: Hook up new "rtc_enable_sctp" build argument to "HAVE_SCTP" define. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hook up new "rtc_enable_sctp" build argument to "HAVE_SCTP" define. This allows building without SCTP support (and even building/running tests). The "HAVE_SCTP" define has been functional for a while, but there wasn't any easy way to turn it on/off. NOTRY=True BUG=webrtc:6933 Review-Url: https://codereview.webrtc.org/2593313002 Cr-Commit-Position: refs/heads/master@{#15763} Committed: https://chromium.googlesource.com/external/webrtc/+/40610e24ceb4662b9435b36172c62046fd796900

Patch Set 1 #

Patch Set 2 : Use a different variable (rtc_enable_sctp). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M webrtc/BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/api/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionendtoend_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/rtcstats_integrationtest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 3 chunks +12 lines, -4 lines 0 comments Download
M webrtc/pc/BUILD.gn View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Taylor Brandstetter
PTAL. I ran into this while working on some SCTP-related refactoring and thought it should ...
4 years ago (2016-12-22 00:41:53 UTC) #2
kjellander_webrtc
lgtm assuming bots are happy.
4 years ago (2016-12-22 08:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593313002/20001
4 years ago (2016-12-22 17:18:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/19605)
4 years ago (2016-12-22 17:28:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593313002/20001
4 years ago (2016-12-22 18:51:23 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 18:53:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/40610e24ceb4662b9435b3617...

Powered by Google App Engine
This is Rietveld 408576698