Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2593003002: Refactor webrtc/modules/audio_conference_mixer for GN check (Closed)

Created:
4 years ago by mbonadei
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/audio_conference_mixer for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/audio_conference_mixer/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2593003002 Cr-Commit-Position: refs/heads/master@{#15759} Committed: https://chromium.googlesource.com/external/webrtc/+/000d16396e748c7593ac41b24a876a6c20f0d277

Patch Set 1 #

Patch Set 2 : Removing .gn changes to run chromium trybots #

Patch Set 3 : Revert "Removing .gn changes to run chromium trybots" #

Patch Set 4 : Revert "Removing .gn changes to run chromium trybots" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mbonadei
4 years ago (2016-12-21 14:54:42 UTC) #2
kjellander_webrtc
lgtm, but since we had a very hard-to-spot breakage in another CL, let's run Chromium ...
4 years ago (2016-12-22 08:20:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2593003002/60001
4 years ago (2016-12-22 14:54:26 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-22 14:56:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/000d16396e748c7593ac41b24...

Powered by Google App Engine
This is Rietveld 408576698