Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2592913003: Convert CRLF to unix newlines in resources/audio_coding/READ.ME (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True NOPRESUBMIT=True R=mbonadei@webrtc.org Review-Url: https://codereview.webrtc.org/2592913003 . Cr-Commit-Position: refs/heads/master@{#15758} Committed: https://chromium.googlesource.com/external/webrtc/+/fb78c3e6fcb2c0499034f76d67894fe25b3f74d9

Patch Set 1 #

Patch Set 2 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M resources/audio_coding/READ.ME View 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kjellander_webrtc
Now here's a simple review. Doesn't get much simpler than this :) It was annoyingly ...
4 years ago (2016-12-21 08:17:52 UTC) #3
mbonadei
lgtm
4 years ago (2016-12-21 08:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2592913003/1
4 years ago (2016-12-21 08:27:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11658)
4 years ago (2016-12-21 08:29:17 UTC) #8
kjellander_webrtc
On 2016/12/21 08:29:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-21 09:54:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2592913003/1
4 years ago (2016-12-22 11:34:06 UTC) #12
commit-bot: I haz the power
Failed to apply patch for resources/audio_coding/READ.ME: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-22 11:34:12 UTC) #14
kjellander_webrtc
4 years ago (2016-12-22 12:46:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb78c3e6fcb2c0499034f76d67894fe25b3f74d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698