|
|
Created:
4 years ago by kjellander_webrtc Modified:
4 years ago Reviewers:
mbonadei CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionConvert CRLF to unix newlines in resources/audio_coding/READ.ME
This file shows up with whitespace changes when importing the code
into a downstream project
BUG=None
NOTRY=True
NOPRESUBMIT=True
R=mbonadei@webrtc.org
Review-Url: https://codereview.webrtc.org/2592913003 .
Cr-Commit-Position: refs/heads/master@{#15758}
Committed: https://chromium.googlesource.com/external/webrtc/+/fb78c3e6fcb2c0499034f76d67894fe25b3f74d9
Patch Set 1 #Patch Set 2 : _ #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True ========== to ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True ==========
kjellander@webrtc.org changed reviewers: + mbonadei@webrtc.org
Now here's a simple review. Doesn't get much simpler than this :) It was annoyingly showing up as a changed file due to the Windows line endings.
lgtm
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11658)
On 2016/12/21 08:29:17, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11658) Ah, I forgot the trybot patching have had issues with windows newlines. It's a known bug and I'm going to just commit manually.
Description was changed from ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True ========== to ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True NOPRESUBMIT=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for resources/audio_coding/READ.ME: While running git apply --index -p1; error: patch failed: resources/audio_coding/READ.ME:1 error: resources/audio_coding/READ.ME: patch does not apply Patch: resources/audio_coding/READ.ME Index: resources/audio_coding/READ.ME diff --git a/resources/audio_coding/READ.ME b/resources/audio_coding/READ.ME index e42b9b3ebbce4e0ef839c24bcdbca1393a07732b..4a021a6a3f6408ccb5fb8686b231be2dd878b0f7 100644 --- a/resources/audio_coding/READ.ME +++ b/resources/audio_coding/READ.ME @@ -1,18 +1,18 @@ -Test files for Audio Coding Module - -testfile32kHz.pcm - mono speech file samples at 32 kHz -teststereo32kHz.pcm - stereo speech file samples at 32 kHz - -Test and reference vectors to verify correct execution of PacketCable -iLBC Fixed Point Reference Code - -Version 1.0.6 -Format: all .INP and .OUT files contain 16 bit sampled data using the -Intel (PC) format. The .BIT files are stored in the appropriate byte -sequence (big-endian format). - -*.INP - input files -*.BIT20 - bit stream files 20 ms mode -*.OUT20 - output files 20 ms mode (on a channel without packet loss) -*.BIT30 - bit stream files 30 ms mode -*.OUT30 - output files 30 ms mode (on a channel without packet loss) +Test files for Audio Coding Module + +testfile32kHz.pcm - mono speech file samples at 32 kHz +teststereo32kHz.pcm - stereo speech file samples at 32 kHz + +Test and reference vectors to verify correct execution of PacketCable +iLBC Fixed Point Reference Code + +Version 1.0.6 +Format: all .INP and .OUT files contain 16 bit sampled data using the +Intel (PC) format. The .BIT files are stored in the appropriate byte +sequence (big-endian format). + +*.INP - input files +*.BIT20 - bit stream files 20 ms mode +*.OUT20 - output files 20 ms mode (on a channel without packet loss) +*.BIT30 - bit stream files 30 ms mode +*.OUT30 - output files 30 ms mode (on a channel without packet loss)
Description was changed from ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True NOPRESUBMIT=True ========== to ========== Convert CRLF to unix newlines in resources/audio_coding/READ.ME This file shows up with whitespace changes when importing the code into a downstream project BUG=None NOTRY=True NOPRESUBMIT=True R=mbonadei@webrtc.org Review-Url: https://codereview.webrtc.org/2592913003 . Cr-Commit-Position: refs/heads/master@{#15758} Committed: https://chromium.googlesource.com/external/webrtc/+/fb78c3e6fcb2c0499034f76d6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as fb78c3e6fcb2c0499034f76d67894fe25b3f74d9 (presubmit successful). |