Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful again.

Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful again.

This test was inadvertently made useless in https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.

This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything interesting...

TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851
Review-Url: https://codereview.webrtc.org/2592693002
Cr-Commit-Position: refs/heads/master@{#15859}
Committed: https://chromium.googlesource.com/external/webrtc/+/20d4547e5db4b48807e151b61da00aa08bf38068

[brandtr, 2016-12-20 14:57:12]

Description was changed from

==========
Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful
again.

This test was inadvertently made useless in
https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.

This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything...

TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851
==========

to

==========
Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful
again.

This test was inadvertently made useless in
https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.

This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything interesting...

TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851
==========

[brandtr, 2016-12-20 15:02:43]

brandtr@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2016-12-22 06:32:47]

lgtm

[brandtr, 2017-01-02 08:00:45]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 08:00:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-02 08:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 08:30:46]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-01-02 08:32:28]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-01-02 08:32:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-02 08:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483345948497460, "parent_rev":
"a82775f6a6c77f7d937fc1f638aca7bc46f26693", "commit_rev":
"20d4547e5db4b48807e151b61da00aa08bf38068"}

[commit-bot: I haz the power, 2017-01-02 08:34:29]

Description was changed from

==========
Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful
again.

This test was inadvertently made useless in
https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.

This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything interesting...

TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851
==========

to

==========
Make VideoSendStreamTest.DoesNotUtilizeUlpfecForH264WithNackEnabled useful
again.

This test was inadvertently made useless in
https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.

This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything interesting...

TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851

Review-Url: https://codereview.webrtc.org/2592693002
Cr-Commit-Position: refs/heads/master@{#15859}
Committed:
https://chromium.googlesource.com/external/webrtc/+/20d4547e5db4b48807e151b61...
==========

[commit-bot: I haz the power, 2017-01-02 08:34:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/20d4547e5db4b48807e151b61...