Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2591733002: Move nat-related code to target rtc_base_tests_utils. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move nat-related code to target rtc_base_tests_utils. BUG=None Review-Url: https://codereview.webrtc.org/2591733002 Cr-Commit-Position: refs/heads/master@{#15728} Committed: https://chromium.googlesource.com/external/webrtc/+/01c715096f9e7aa3701ed3893e3527b587af0a89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
As far as I understand, this NAT code is used only by tests.
4 years ago (2016-12-20 13:15:17 UTC) #2
kjellander_webrtc
lgtm assuming ours, Chromium's and the internal trybots are happy.
4 years ago (2016-12-20 13:51:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2591733002/1
4 years ago (2016-12-21 08:01:40 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-21 08:23:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/01c715096f9e7aa3701ed3893...

Powered by Google App Engine
This is Rietveld 408576698