Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2590823002: Remove use of PCH files in webrtc/sdk/objc (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use of PCH files in webrtc/sdk/objc A decision has been made to not use prefix header files. BUG=None Review-Url: https://codereview.webrtc.org/2590823002 Cr-Commit-Position: refs/heads/master@{#16056} Committed: https://chromium.googlesource.com/external/webrtc/+/bf0845201a3850a0aad9a11c974162e39ac897bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCNSGLVideoView.m View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCShader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCNSGLVideoView.h View 1 chunk +2 lines, -0 lines 0 comments Download
D webrtc/sdk/objc/WebRTC-Prefix.pch View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
magjed_webrtc
Zeke - please take a look.
4 years ago (2016-12-20 12:33:22 UTC) #12
magjed_webrtc
Kári - please take a look.
3 years, 11 months ago (2017-01-13 12:33:02 UTC) #14
kthelgason
lgtm
3 years, 11 months ago (2017-01-13 13:03:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2590823002/20001
3 years, 11 months ago (2017-01-13 13:03:21 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 15:10:20 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/bf0845201a3850a0aad9a11c9...

Powered by Google App Engine
This is Rietveld 408576698