Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2590813002: Remove media/base header files from rtc_media target (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove media/base header files from rtc_media target Chromium has now been updated, so we can remove the base headers from rtc_media. BUG=None Review-Url: https://codereview.webrtc.org/2590813002 Cr-Commit-Position: refs/heads/master@{#15712} Committed: https://chromium.googlesource.com/external/webrtc/+/a3f2d3018267f43affc4d95e04c8e69c6ef96bd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Philip - please take a look.
4 years ago (2016-12-20 10:33:18 UTC) #5
philipel
lgtm
4 years ago (2016-12-20 10:35:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2590813002/1
4 years ago (2016-12-20 13:25:23 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 13:27:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a3f2d3018267f43affc4d95e0...

Powered by Google App Engine
This is Rietveld 408576698