Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2590753002: Implement current/pending session description methods. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement current/pending session description methods. BUG=webrtc:6917 Review-Url: https://codereview.webrtc.org/2590753002 Cr-Commit-Position: refs/heads/master@{#15722} Committed: https://chromium.googlesource.com/external/webrtc/+/fe4a8a41adf704485b6f3bad4660fb56b58c7868

Patch Set 1 #

Patch Set 2 : Comment formatting. #

Patch Set 3 : Remove unneeded comment. #

Patch Set 4 : Fixing null pointer deref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -52 lines) Patch
M webrtc/api/peerconnection.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 2 3 chunks +31 lines, -4 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 1 2 3 21 chunks +75 lines, -48 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Taylor Brandstetter
PTAL. I ended up needing "current description" for another CL, so I decided to implement ...
4 years ago (2016-12-20 03:56:34 UTC) #2
pthatcher1
lgtm
4 years ago (2016-12-21 00:59:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2590753002/40001
4 years ago (2016-12-21 01:12:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/8597) mac_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-12-21 01:19:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2590753002/60001
4 years ago (2016-12-21 01:34:21 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-21 01:56:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/fe4a8a41adf704485b6f3bad4...

Powered by Google App Engine
This is Rietveld 408576698