Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Issue 2590153002: Revert of Add disabled certificate check support to IceServer PeerConnection API. (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add disabled certificate check support to IceServer PeerConnection API. (patchset #8 id:140001 of https://codereview.webrtc.org/2557803002/ ) Reason for revert: This CL broke all Chromium WebRTC FYI bots. A roll+fix was attempted here: https://codereview.chromium.org/2590783003/, but failed to land. I'm reverting this CL now to make the tree green again. Make the API change gradual when you reland so that we can update Chromium between. Original issue's description: > Add disabled certificate check support to IceServer PeerConnection API. > > Refactor "OPT_SSLTCP" renaming it to "OPT_TLS_FAKE", making it clear > that it's not actually some kind of SSL over TCP. Also making it clear > that it's mutually exclusive with OPT_TLS. > > Add "OPT_TLS_INSECURE" that implements the new certificate-check > disabled TLS mode, which is also mutually exclusive with the other > TLS options. > > PortAllocator: Add a new TLS policy enum TlsCertPolicy which defines > the new insecure mode and added it as a RelayCredentials member. > > TurnPort: Add new TLS policy member with appropriate getter and setter > to avoid constructor bloat. Initialize it from the RelayCredentials > after the TurnPort is created. > > Expose the new feature in the PeerConnection API via > IceServer.tls_certificate_policy as well as via the Android JNI > PeerConnection API. > > For security reasons we ensure that: > > 1) The policy is always explicitly initialized to secure. > 2) API users have to explicitly integrate with the feature to > use it, and will otherwise get no change in behavior. > 3) The feature is not immediately exposed in non-native > contexts. For example, disabling of certificate validation > is not implemented via URI parsing since this would > immediately allow it to be used from a web page. > > BUG=webrtc:6840 > > Review-Url: https://codereview.webrtc.org/2557803002 > Cr-Commit-Position: refs/heads/master@{#15670} > Committed: https://chromium.googlesource.com/external/webrtc/+/b0f04fdb9eb8b28424b7f80e38f4936e5c501b7b TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,hnsl@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6840 Review-Url: https://codereview.webrtc.org/2590153002 Cr-Commit-Position: refs/heads/master@{#15703} Committed: https://chromium.googlesource.com/external/webrtc/+/d5236e2948dd674532419837d94f0438f56d251d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -137 lines) Patch
M webrtc/api/peerconnection.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +1 line, -14 lines 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M webrtc/p2p/base/packetsocketfactory.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/p2p/base/tcpport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnport.h View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnection.java View 3 chunks +1 line, -13 lines 0 comments Download
M webrtc/sdk/android/src/jni/classreferenceholder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
magjed_webrtc
Created Revert of Add disabled certificate check support to IceServer PeerConnection API.
4 years ago (2016-12-20 10:21:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2590153002/1
4 years ago (2016-12-20 10:21:59 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-20 10:22:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d5236e2948dd674532419837d...

Powered by Google App Engine
This is Rietveld 408576698