Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2589833002: Clean up storage of FlexFEC payload type in webrtc::VideoCodecSettings. (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up storage of FlexFEC payload type in webrtc::VideoCodecSettings. No need to pass a whole struct around, when only one member is used. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2589833002 Cr-Commit-Position: refs/heads/master@{#15687} Committed: https://chromium.googlesource.com/external/webrtc/+/bb7066f9662a638f2f3b2f6100880ca595da0c3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
brandtr
Please have a look :)
4 years ago (2016-12-19 15:39:57 UTC) #2
magjed_webrtc
lgtm
4 years ago (2016-12-19 16:23:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589833002/1
4 years ago (2016-12-19 16:28:31 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-19 17:41:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bb7066f9662a638f2f3b2f610...

Powered by Google App Engine
This is Rietveld 408576698