Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2589393002: Revert of Parse FlexFEC RTP headers in Call and add integration with BWE. (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Parse FlexFEC RTP headers in Call and add integration with BWE. (patchset #17 id:460001 of https://codereview.webrtc.org/2553863003/ ) Reason for revert: Unexpected perf regressions. Original issue's description: > Parse FlexFEC RTP headers in Call and add integration with BWE. > > BUG=webrtc:5654 > > Review-Url: https://codereview.webrtc.org/2553863003 > Cr-Commit-Position: refs/heads/master@{#15709} > Committed: https://chromium.googlesource.com/external/webrtc/+/ab2ffa3b28b55ef359232723049fb88b2dcd807a TBR=philipel@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2589393002 Cr-Commit-Position: refs/heads/master@{#15727} Committed: https://chromium.googlesource.com/external/webrtc/+/70e4053844d06377aaa2142a64b90037d74bbcf9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -296 lines) Patch
M webrtc/call/call.cc View 12 chunks +20 lines, -103 lines 0 comments Download
M webrtc/call/flexfec_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/flexfec_receive_stream_impl.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_impl.cc View 6 chunks +12 lines, -13 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_unittest.cc View 4 chunks +23 lines, -18 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc View 6 chunks +34 lines, -22 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc View 27 chunks +68 lines, -52 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Parse FlexFEC RTP headers in Call and add integration with BWE.
4 years ago (2016-12-21 08:20:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589393002/1
4 years ago (2016-12-21 08:20:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/70e4053844d06377aaa2142a64b90037d74bbcf9
4 years ago (2016-12-21 08:22:06 UTC) #6
brandtr
4 years ago (2016-12-21 08:35:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2595853002/ by brandtr@webrtc.org.

The reason for reverting is: WIP.

Powered by Google App Engine
This is Rietveld 408576698