Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2589233002: Make magjed@ owner of webrtc/sdk/objc (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make magjed@ owner of webrtc/sdk/objc Also, move owner file from webrtc/sdk to webrtc/sdk/objc since we now also have webrtc/sdk/android directory. BUG=None TBR=tkchin NOTRY=True Review-Url: https://codereview.webrtc.org/2589233002 Cr-Commit-Position: refs/heads/master@{#15961} Committed: https://chromium.googlesource.com/external/webrtc/+/29fe6f338fdd632708073e03dba21f41599a4a2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
D webrtc/sdk/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
magjed_webrtc
Zeke - please take a look.
4 years ago (2016-12-20 12:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589233002/1
3 years, 11 months ago (2017-01-09 10:11:10 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-09 10:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589233002/1
3 years, 11 months ago (2017-01-09 12:17:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/29fe6f338fdd632708073e03dba21f41599a4a2e
3 years, 11 months ago (2017-01-09 12:20:34 UTC) #13
tkchin_webrtc
3 years, 11 months ago (2017-01-09 18:11:12 UTC) #14
Message was sent while issue was closed.
On 2017/01/09 12:20:34, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/29fe6f338fdd632708073e03d...

lgtm

Powered by Google App Engine
This is Rietveld 408576698