Style renames in RTCPReceiver implementation

Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
add 'ntp' suffix to time variables derived from ntp time.
No functional changes expected.

BUG=None

Review-Url: https://codereview.webrtc.org/2588753002
Cr-Commit-Position: refs/heads/master@{#15706}
Committed: https://chromium.googlesource.com/external/webrtc/+/8bab796db717c7edef29b79ea208b14d557b964b

[danilchap, 2016-12-19 15:20:08]

Description was changed from

==========
Style cleanup in RTCPReceiver
Rename variables and private function to follow style,
replace remaining asserts with DCHECKs.
No functional changes expected.

BUG=None
==========

to

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
No functional changes expected.

BUG=None
==========

[danilchap, 2016-12-19 15:21:14]

Description was changed from

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
No functional changes expected.

BUG=None
==========

to

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
No functional changes expected.

BUG=None
==========

[danilchap, 2016-12-19 15:24:06]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[danilchap, 2016-12-19 15:24:41]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 15:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[philipel, 2016-12-19 15:39:07]

lg

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:265: uint32_t receive_time =
CompactNtp(last_received_xr_ntp_);
receive_time_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:266: uint32_t now =
CompactNtp(NtpTime(*clock_));
now_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:502: uint32_t send_time =
report_block.last_sr();
send_time_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:508: uint32_t delay =
report_block.delay_since_last_sr();
delay_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:510: uint32_t receive_time =
CompactNtp(NtpTime(*clock_));
receive_time_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:726: uint32_t now =
CompactNtp(NtpTime(*clock_));
now_ntp

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:37: class RTCPReceiver {
RtcpReceiver? Or maybe that is for another CL...

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:67: void SetRemoteSSRC(uint32_t
ssrc);
SetRemoteSsrc

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:68: uint32_t RemoteSSRC() const;
RemoteSsrc

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:71: int32_t CNAME(uint32_t
remote_ssrc, char cname[RTCP_CNAME_SIZE]) const;
Cname

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:83: int32_t RTT(uint32_t
remote_ssrc,
Rtt

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:109: bool
UpdateRTCPReceiveInformationTimers();
UpdateRtcpReceiveInformationTimers

[danilchap, 2016-12-19 16:36:54]

Description was changed from

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
No functional changes expected.

BUG=None
==========

to

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
add 'ntp' suffix to time variables derived from ntp time.
No functional changes expected.

BUG=None
==========

[danilchap, 2016-12-19 16:37:56]

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:265: uint32_t receive_time =
CompactNtp(last_received_xr_ntp_);
On 2016/12/19 15:39:07, philipel wrote:
> receive_time_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:266: uint32_t now =
CompactNtp(NtpTime(*clock_));
On 2016/12/19 15:39:07, philipel wrote:
> now_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:502: uint32_t send_time =
report_block.last_sr();
On 2016/12/19 15:39:07, philipel wrote:
> send_time_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:508: uint32_t delay =
report_block.delay_since_last_sr();
On 2016/12/19 15:39:07, philipel wrote:
> delay_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:510: uint32_t receive_time =
CompactNtp(NtpTime(*clock_));
On 2016/12/19 15:39:07, philipel wrote:
> receive_time_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:726: uint32_t now =
CompactNtp(NtpTime(*clock_));
On 2016/12/19 15:39:07, philipel wrote:
> now_ntp

Done.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:37: class RTCPReceiver {
On 2016/12/19 15:39:07, philipel wrote:
> RtcpReceiver? Or maybe that is for another CL...

prefer to leave for another CL
changing name would require adjusting other classes (RtpRtcpImpl and
RtcpReceiver fuzzer)

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:67: void SetRemoteSSRC(uint32_t
ssrc);
On 2016/12/19 15:39:07, philipel wrote:
> SetRemoteSsrc

Prefer to change public methods in a different CL.
(CL description explicitly mention only private methods were renamed)
Changing public methods is a bit more risky because require changing users of
this class.

[philipel, 2016-12-20 09:55:56]

lgtm

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:37: class RTCPReceiver {
On 2016/12/19 16:37:56, danilchap wrote:
> On 2016/12/19 15:39:07, philipel wrote:
> > RtcpReceiver? Or maybe that is for another CL...
> 
> prefer to leave for another CL
> changing name would require adjusting other classes (RtpRtcpImpl and
> RtcpReceiver fuzzer)

Acknowledged.

https://codereview.webrtc.org/2588753002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:67: void SetRemoteSSRC(uint32_t
ssrc);
On 2016/12/19 16:37:56, danilchap wrote:
> On 2016/12/19 15:39:07, philipel wrote:
> > SetRemoteSsrc
> 
> Prefer to change public methods in a different CL.
> (CL description explicitly mention only private methods were renamed)
> Changing public methods is a bit more risky because require changing users of
> this class.

Acknowledged.

[danilchap, 2016-12-20 10:00:50]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-12-20 10:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-20 10:46:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482228050302860,
"parent_rev": "cb29be5cfae6343f53be76f5e7dfa4d6fb2818ee", "commit_rev":
"8bab796db717c7edef29b79ea208b14d557b964b"}

[commit-bot: I haz the power, 2016-12-20 10:46:49]

Description was changed from

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
add 'ntp' suffix to time variables derived from ntp time.
No functional changes expected.

BUG=None
==========

to

==========
Style cleanup in RTCPReceiver
Rename variables and private functions to follow style,
replace remaining asserts with DCHECKs.
add 'ms' suffix to time variables derived from clock_
add 'ntp' suffix to time variables derived from ntp time.
No functional changes expected.

BUG=None

Review-Url: https://codereview.webrtc.org/2588753002
Cr-Commit-Position: refs/heads/master@{#15706}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8bab796db717c7edef29b79ea...
==========

[commit-bot: I haz the power, 2016-12-20 10:46:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8bab796db717c7edef29b79ea...