Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: webrtc/video/payload_router_unittest.cc

Issue 2588343002: Delete unused method PayloadRouter::MaxPayloadLength. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/payload_router.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/payload_router_unittest.cc
diff --git a/webrtc/video/payload_router_unittest.cc b/webrtc/video/payload_router_unittest.cc
index 935de5f3e94c4b14e5ae7d88db4b8eb9888f5736..e316695338a1c7a7e31a8a46afa727dc3b0f88eb 100644
--- a/webrtc/video/payload_router_unittest.cc
+++ b/webrtc/video/payload_router_unittest.cc
@@ -149,40 +149,6 @@ TEST(PayloadRouterTest, SendSimulcast) {
.error);
}
-TEST(PayloadRouterTest, MaxPayloadLength) {
- // Without any limitations from the modules, verify we get the max payload
- // length for IP/UDP/SRTP with a MTU of 150 bytes.
- const size_t kDefaultMaxLength = 1500 - 20 - 8 - 12 - 4;
- NiceMock<MockRtpRtcp> rtp_1;
- NiceMock<MockRtpRtcp> rtp_2;
- std::vector<RtpRtcp*> modules;
- modules.push_back(&rtp_1);
- modules.push_back(&rtp_2);
- PayloadRouter payload_router(modules, 42);
-
- EXPECT_EQ(kDefaultMaxLength, PayloadRouter::DefaultMaxPayloadLength());
- std::vector<VideoStream> streams(2);
-
- // Modules return a higher length than the default value.
- EXPECT_CALL(rtp_1, MaxDataPayloadLength())
- .Times(1)
- .WillOnce(Return(kDefaultMaxLength + 10));
- EXPECT_CALL(rtp_2, MaxDataPayloadLength())
- .Times(1)
- .WillOnce(Return(kDefaultMaxLength + 10));
- EXPECT_EQ(kDefaultMaxLength, payload_router.MaxPayloadLength());
-
- // The modules return a value lower than default.
- const size_t kTestMinPayloadLength = 1001;
- EXPECT_CALL(rtp_1, MaxDataPayloadLength())
- .Times(1)
- .WillOnce(Return(kTestMinPayloadLength + 10));
- EXPECT_CALL(rtp_2, MaxDataPayloadLength())
- .Times(1)
- .WillOnce(Return(kTestMinPayloadLength));
- EXPECT_EQ(kTestMinPayloadLength, payload_router.MaxPayloadLength());
-}
-
TEST(PayloadRouterTest, SimulcastTargetBitrate) {
NiceMock<MockRtpRtcp> rtp_1;
NiceMock<MockRtpRtcp> rtp_2;
« no previous file with comments | « webrtc/video/payload_router.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698