Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2588343002: Delete unused method PayloadRouter::MaxPayloadLength. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method PayloadRouter::MaxPayloadLength. Documentation was also unclear, it seems it returned the RTP packet size including RTP headers. BUG=None. Review-Url: https://codereview.webrtc.org/2588343002 Cr-Commit-Position: refs/heads/master@{#15707} Committed: https://chromium.googlesource.com/external/webrtc/+/5206667dadd69d30309dc69cc866925299b0efe1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M webrtc/video/payload_router.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/video/payload_router.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nisse-webrtc
PTAL. Related to the cleanup effort in cl https://codereview.webrtc.org/2589743002/
4 years ago (2016-12-20 09:20:37 UTC) #2
nisse-webrtc
It seems Erik is on vacation this week. Stefan, can you have a look instead?
4 years ago (2016-12-20 10:24:33 UTC) #4
stefan-webrtc
lgtm
4 years ago (2016-12-20 10:30:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2588343002/1
4 years ago (2016-12-20 10:36:33 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-20 11:12:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5206667dadd69d30309dc69cc...

Powered by Google App Engine
This is Rietveld 408576698