Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2588333002: Move last of third_party dirs into DEPS entries (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move last of third_party dirs into DEPS entries BUG=webrtc:5006 TBR=charujain@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2588333002 Cr-Commit-Position: refs/heads/master@{#15701} Committed: https://chromium.googlesource.com/external/webrtc/+/0012d183b8596649d52134ebfda993cb1cf140af

Patch Set 1 #

Patch Set 2 : Remove llvm-build from .gitignore #

Patch Set 3 : Remove junit-jar from .gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3157 lines) Patch
M .gitignore View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M DEPS View 1 chunk +7 lines, -3 lines 0 comments Download
D third_party/gflags/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/gflags/LICENSE View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/gflags/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/gflags/README.webrtc View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/gflags/gen/posix/include/gflags/gflags.h View 1 chunk +0 lines, -573 lines 0 comments Download
D third_party/gflags/gen/posix/include/gflags/gflags_completions.h View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/gflags/gen/posix/include/gflags/gflags_declare.h View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/gflags/gen/posix/include/gflags/gflags_gflags.h View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/gflags/gen/posix/include/private/config.h View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/gflags/gen/win/include/gflags/gflags.h View 1 chunk +0 lines, -573 lines 0 comments Download
D third_party/gflags/gen/win/include/gflags/gflags_completions.h View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/gflags/gen/win/include/gflags/gflags_declare.h View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/gflags/gen/win/include/gflags/gflags_gflags.h View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/gflags/gen/win/include/private/config.h View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/gtest-parallel/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/gtest-parallel/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/gtest-parallel/README.webrtc View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/gtest-parallel/gtest-parallel View 1 chunk +0 lines, -478 lines 0 comments Download
D third_party/gtest-parallel/gtest-parallel-wrapper.py View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/winsdk_samples/BUILD.gn View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/winsdk_samples/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/winsdk_samples/README.webrtc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2588333002/40001
4 years ago (2016-12-20 09:34:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2588333002/40001
4 years ago (2016-12-20 09:34:48 UTC) #11
kjellander_webrtc
On 2016/12/20 09:34:25, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years ago (2016-12-20 09:36:20 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/0012d183b8596649d52134ebfda993cb1cf140af
4 years ago (2016-12-20 09:36:38 UTC) #15
brandtr
On 2016/12/20 09:36:38, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as ...
4 years ago (2016-12-21 11:47:15 UTC) #16
kjellander_webrtc
4 years ago (2016-12-21 12:51:42 UTC) #17
Message was sent while issue was closed.
On 2016/12/21 11:47:15, brandtr wrote:
> On 2016/12/20 09:36:38, commit-bot: I haz the power wrote:
> > Committed patchset #3 (id:40001) as
> >
>
https://chromium.googlesource.com/external/webrtc/+/0012d183b8596649d52134ebf...
> 
> After this change, the "third_party/llvm-build" directory is showing up as
> untracked directory in my git checkout, whenever I run "gclient sync" or
> "gclient runhooks". I guess that is not supposed to happen, so is this
directory
> downloaded by mistake somehow?

I was afraid it was needed for tryjobs in my work of
https://codereview.webrtc.org/1414343008/ but I can restore it since I actually
think it doesn't matter if the dir is there.

Powered by Google App Engine
This is Rietveld 408576698