Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2587423002: Drop unneeded includes of base/stream.h. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop unneeded includes of base/stream.h. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2587423002 Cr-Commit-Position: refs/heads/master@{#15986} Committed: https://chromium.googlesource.com/external/webrtc/+/989ec098d13525cf948926bcf403b03baa50e051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M webrtc/base/base64_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/fileutils.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
nisse-webrtc
3 years, 11 months ago (2017-01-09 15:35:35 UTC) #2
pthatcher1
lgtm
3 years, 11 months ago (2017-01-09 23:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2587423002/1
3 years, 11 months ago (2017-01-10 07:46:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12022)
3 years, 11 months ago (2017-01-10 07:50:00 UTC) #7
nisse-webrtc
Magnus: OWNER's approval needed for a dropped include line in a file under common_video. Have ...
3 years, 11 months ago (2017-01-10 07:58:34 UTC) #10
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-10 10:23:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2587423002/1
3 years, 11 months ago (2017-01-10 11:42:47 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 11:44:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/989ec098d13525cf948926bcf...

Powered by Google App Engine
This is Rietveld 408576698