Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2586783003: Revert of Properly report number of quality downscales in stats. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Properly report number of quality downscales in stats. (patchset #11 id:220001 of https://codereview.webrtc.org/2564373002/ ) Reason for revert: Breaks perf tests Original issue's description: > Properly report number of quality downscales in stats. > > A regression was introduced in 876222f that caused these stats to > be reported incorrectly. This used to be only implemented for VP8 > but should now be available for all codecs. > > BUG=webrtc:6860 > > Review-Url: https://codereview.webrtc.org/2564373002 > Cr-Commit-Position: refs/heads/master@{#15673} > Committed: https://chromium.googlesource.com/external/webrtc/+/0c8c5388355f5df085595d9ea24fa38995708120 TBR=asapersson@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6860 Review-Url: https://codereview.webrtc.org/2586783003 Cr-Commit-Position: refs/heads/master@{#15678} Committed: https://chromium.googlesource.com/external/webrtc/+/fe04bd43cc7a7d45ce59a2a83d716a68d06b5e92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -69 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 3 chunks +20 lines, -25 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 5 chunks +13 lines, -22 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 8 chunks +9 lines, -12 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kthelgason
Created Revert of Properly report number of quality downscales in stats.
4 years ago (2016-12-19 14:17:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2586783003/1
4 years ago (2016-12-19 14:17:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fe04bd43cc7a7d45ce59a2a83d716a68d06b5e92
4 years ago (2016-12-19 14:17:33 UTC) #6
kthelgason
4 years ago (2016-12-19 14:31:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2588743002/ by kthelgason@webrtc.org.

The reason for reverting is: Bug affecting perf tests has been fixed. The issue
was that I had accidentally disabled cpu overuse adaptation based on the
encoders ScalingSettings, not just quality-based scaling..

Powered by Google App Engine
This is Rietveld 408576698