Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2586433002: Compile ios helpers on mac as well. (Closed)

Created:
4 years ago by kthelgason
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Compile ios helpers on mac as well. BUG=webrtc:5582 Review-Url: https://codereview.webrtc.org/2586433002 Cr-Commit-Position: refs/heads/master@{#16604} Committed: https://chromium.googlesource.com/external/webrtc/+/1f16ee38c16f43c812ccc4201831fdc44cdd93bf

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webrtc/sdk/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/helpers.mm View 1 5 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kthelgason
Small CL, please take a look when you have time :)
4 years ago (2016-12-16 10:41:27 UTC) #2
kthelgason
Ping Zeke :) please take a look when you have time. Should be quick.
3 years, 11 months ago (2017-01-23 12:25:12 UTC) #3
kthelgason
Magnus, please take a look.
3 years, 10 months ago (2017-02-10 14:32:16 UTC) #5
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-13 12:47:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2586433002/1
3 years, 10 months ago (2017-02-13 15:31:31 UTC) #8
commit-bot: I haz the power
Failed to apply patch for webrtc/sdk/objc/Framework/Classes/helpers.mm: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-13 16:25:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2586433002/20001
3 years, 10 months ago (2017-02-14 09:56:41 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 11:08:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1f16ee38c16f43c812ccc4201...

Powered by Google App Engine
This is Rietveld 408576698