Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585813002:
Espresso test case to control loopback call (Closed)
DescriptionEspresso test case to control loopback call
The test case is put inside a new test target. That test target will be started from a test script to asses video quality.
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2585813002
Cr-Commit-Position: refs/heads/master@{#16088}
Committed: https://chromium.googlesource.com/external/webrtc/+/a6069e8a0102c97ef50e5aaf63bd3034f3322d5f
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add forgotten file ConnectActivityStubbedInputOutputTest.java #Patch Set 3 : Only keeping necessary dependencies in BUILD.gn for the test case #
Total comments: 16
Patch Set 4 : Moved ConnectActivityStubbedInputOutputTest to its own target and fixed other review comments #
Total comments: 5
Patch Set 5 : Merge branch 'master' into loopback_espresso #Patch Set 6 : Removed deps from webrtc/examples/BUILD.gn #Patch Set 7 : Dependency issue addressed #
Total comments: 5
Patch Set 8 : Fixed review comments and added missing .sha1 for video file #
Total comments: 2
Patch Set 9 : Removed some warnings and put static imports before non-static imports #Patch Set 10 : Removed unnecessary imports #Patch Set 11 : Merge from master and use of Environment.getExternalStorageDirectory() instead of hardcoded /sdcard… #
Total comments: 1
Messages
Total messages: 54 (32 generated)
mandermo@webrtc.org changed reviewers: + jansson@webrtc.org, kjellander@webrtc.org
Espresso test case to control loopback call.
I'm missing ConnectActivityStubbedInputOutputTest.java. I assume you missed to add it? https://codereview.webrtc.org/2585813002/diff/1/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/1/webrtc/examples/BUILD.gn#newc... webrtc/examples/BUILD.gn:124: "//third_party/espresso:espresso_all_java", Do you know all these are needed? I'd prefer a minimal set that makes the test still pass.
Added forgotten file ConnectActivityStubbedInputOutputTest.java and removed unnecessary dependencies I added in BUILD.gn. https://codereview.webrtc.org/2585813002/diff/1/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/1/webrtc/examples/BUILD.gn#newc... webrtc/examples/BUILD.gn:124: "//third_party/espresso:espresso_all_java", On 2016/12/17 18:13:41, kjellander_webrtc wrote: > Do you know all these are needed? I'd prefer a minimal set that makes the test > still pass. Removed unnecessary ones.
Added forgotten file ConnectActivityStubbedInputOutputTest.java and removed unnecessary dependencies I added in BUILD.gn.
https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:16: import java.util.concurrent.CountDownLatch; Is this used? Any other imports that are not used? https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:40: // import static org.junit.framework.Assert.*; Remove. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:48: Maybe add an overall comment explaining what the test does and it's objective? https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:85: IdlingPolicies.setMasterPolicyTimeout(240000, TimeUnit.MILLISECONDS); Add a comment explaining why the master test timeout is changed to 24 seconds. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:86: Thread.sleep(10000); Add a comment here explaining why we are sleeping for 10 seconds.
Please add the right BUG= reference. The test fails with org.appspot.apprtc.test.ConnectActivityStubbedInputOutputTest#testLoopback (run #1): java.lang.RuntimeException: No activities found. Did you forget to launch the activity by calling getActivity() or startActivitySync or similar? at android.support.test.espresso.base.RootViewPicker.waitForAtLeastOneActivityToBeResumed(RootViewPicker.java:189) at android.support.test.espresso.base.RootViewPicker.findRoot(RootViewPicker.java:134) as it is now. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:110: "androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java", I remember we talked about having a Python script wrap around this test execution, so it can: 1) download the video quality toolchain resources 2) run the test 3) pull the video file 4) run compare_videos.py etc. For that to happen (I assume in a follow-up CL), I think it's better we create a separate target for ConnectActivityStubbedInputOutputTest.java than adding it to AppRTCMobileTest. It doesn't really add much value being run on the bots as it is now anyway. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:22: import android.test.InstrumentationTestCase; sort imports https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:73: CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA, "/sdcard/reference_video_640x360_30fps.y4m"); The data section for the GN target only lists "//webrtc/examples/androidtests/src/org/appspot/apprtc/test/capturetestvideo.y4m", so this file won't be present on the device. Please adjust this filename accordingly or update the data list for the target. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:87: onView(withId(R.id.button_call_disconnect)).perform(click()); I thought we were going to wait for a toast to be displayed when writing down the file to disk was completed? Or is that planned for a follow-up CL? If so, add a TODO explaining that here.
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11626)
Description was changed from ========== Espresso test case to control loopback call BUG= ========== to ========== Espresso test case to control loopback call BUG=webrtc:6545 ==========
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Fixed review comments. The failure you go on try bots is probably related to that the video file was not on the device. I have addressed that by adding it to the data field in the GN file. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:22: import android.test.InstrumentationTestCase; On 2016/12/19 11:26:26, kjellander_webrtc wrote: > sort imports Done. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:40: // import static org.junit.framework.Assert.*; On 2016/12/19 10:58:11, janssonWebRTC wrote: > Remove. Done. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:48: On 2016/12/19 10:58:11, janssonWebRTC wrote: > Maybe add an overall comment explaining what the test does and it's objective? Done. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:73: CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA, "/sdcard/reference_video_640x360_30fps.y4m"); On 2016/12/19 11:26:26, kjellander_webrtc wrote: > The data section for the GN target only lists > "//webrtc/examples/androidtests/src/org/appspot/apprtc/test/capturetestvideo.y4m", > so this file won't be present on the device. Please adjust this filename > accordingly or update the data list for the target. capturetestvideo.y4m is needed by other testcase, so I will keep it. Added a new target and added reference_video_640x 360_30fps.y4m there instead. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:85: IdlingPolicies.setMasterPolicyTimeout(240000, TimeUnit.MILLISECONDS); On 2016/12/19 10:58:11, janssonWebRTC wrote: > Add a comment explaining why the master test timeout is changed to 24 seconds. Done. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:87: onView(withId(R.id.button_call_disconnect)).perform(click()); On 2016/12/19 11:26:25, kjellander_webrtc wrote: > I thought we were going to wait for a toast to be displayed when writing down > the file to disk was completed? Or is that planned for a follow-up CL? If so, > add a TODO explaining that here. In the current approach it seams to wait synchronously till the UI thread is not busy, which happens when the file has been written to disk, so it seams to work without the toast.
Getting close now! Generally looks good; just needs a rebase and one comment addressed. https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/40001/webrtc/examples/androidte... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:87: onView(withId(R.id.button_call_disconnect)).perform(click()); On 2016/12/20 15:54:12, mandermo wrote: > On 2016/12/19 11:26:25, kjellander_webrtc wrote: > > I thought we were going to wait for a toast to be displayed when writing down > > the file to disk was completed? Or is that planned for a follow-up CL? If so, > > add a TODO explaining that here. > > In the current approach it seams to wait synchronously till the UI thread is not > busy, which happens when the file has been written to disk, so it seams to work > without the toast. Acknowledged. https://codereview.webrtc.org/2585813002/diff/60001/setup_links.py File setup_links.py (right): https://codereview.webrtc.org/2585813002/diff/60001/setup_links.py#newcode115 setup_links.py:115: 'third_party/ub-uiautomator', setup_links.py no longer exists, but this dependency is now in our DEPS file: https://chromium.googlesource.com/external/webrtc/+/master/DEPS#123 so you should be fine. https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:120: "//third_party/android_support_test_runner:rules_java", Please remove line 120-124 as they're no longer needed for this target.
Fixed review comments. https://codereview.webrtc.org/2585813002/diff/60001/setup_links.py File setup_links.py (right): https://codereview.webrtc.org/2585813002/diff/60001/setup_links.py#newcode115 setup_links.py:115: 'third_party/ub-uiautomator', On 2016/12/27 06:31:42, kjellander_webrtc wrote: > setup_links.py no longer exists, but this dependency is now in our DEPS file: > https://chromium.googlesource.com/external/webrtc/+/master/DEPS#123 so you > should be fine. Should I remove line 115? https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:120: "//third_party/android_support_test_runner:rules_java", On 2016/12/27 06:31:42, kjellander_webrtc wrote: > Please remove line 120-124 as they're no longer needed for this target. I manage to remove all the lines exept line 122, then I get this error: "java.lang.ClassNotFoundException: Didn't find class "android.support.test.runner.AndroidJUnitRunner"
lgtm with the java dependency comment addressed. Also notice I'm not owner here. https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2585813002/diff/60001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:120: "//third_party/android_support_test_runner:rules_java", On 2017/01/03 14:17:58, mandermo wrote: > On 2016/12/27 06:31:42, kjellander_webrtc wrote: > > Please remove line 120-124 as they're no longer needed for this target. > > I manage to remove all the lines exept line 122, then I get this error: > "java.lang.ClassNotFoundException: Didn't find class > "android.support.test.runner.AndroidJUnitRunner" Ah, that's probably related to the AndroidManifest.xml change. Please replace it with //third_party/android_support_test_runner:runner_java instead. The android.support.test.runner.AndroidJUnitRunner class is a part of that target as well: https://cs.chromium.org/chromium/src/third_party/android_support_test_runner/... I verified it by running jar tvf third_party/android_support_test_runner/lib/runner-0.5-release-no-dep.jar |grep AndroidJUnitRunner
mandermo@webrtc.org changed reviewers: + magjed@webrtc.org
Dependency issue addressed. +magjed
Looks good overall, but I have some comments. Also, can you write a brief description in the CL explaining what the new target will do? https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:13: import java.lang.Thread; Please order your imports according to https://google.github.io/styleguide/javaguide.html#s3.3-import-statements and also remove unnecessary imports here. https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:49: // The third parameter is set to false which means the activity is not started automatically. Which parameter are you referring to? I only see false for EXTRA_CAPTURETOTEXTURE_ENABLED and EXTRA_CAMERA2.
Description was changed from ========== Espresso test case to control loopback call BUG=webrtc:6545 ========== to ========== Espresso test case to control loopback call. The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 ==========
Fixed review comments and added missing .sha1 for video file. https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:13: import java.lang.Thread; On 2017/01/10 11:01:06, magjed_webrtc wrote: > Please order your imports according to > https://google.github.io/styleguide/javaguide.html#s3.3-import-statements and > also remove unnecessary imports here. Sorted better and removed spaces. I failed to find unnecessary imports. https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:49: // The third parameter is set to false which means the activity is not started automatically. On 2017/01/10 11:01:06, magjed_webrtc wrote: > Which parameter are you referring to? I only see false for > EXTRA_CAPTURETOTEXTURE_ENABLED and EXTRA_CAMERA2. The comment is out of date, I have removed it now, thanks for noticing
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17533)
Description was changed from ========== Espresso test case to control loopback call. The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 ========== to ========== Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 ==========
https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/120001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:13: import java.lang.Thread; On 2017/01/10 15:32:26, mandermo wrote: > On 2017/01/10 11:01:06, magjed_webrtc wrote: > > Please order your imports according to > > https://google.github.io/styleguide/javaguide.html#s3.3-import-statements and > > also remove unnecessary imports here. > > Sorted better and removed spaces. I failed to find unnecessary imports. The static imports should come first. At least the 'import java.lang.InterruptedException' and 'import java.lang.Thread' are unnecessary. https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:46: public ActivityTestRule<ConnectActivity> rule = new ActivityTestRule(ConnectActivity.class) { I think this is causing a new compile warning? Make sure you don't introduce new warnings. We are trying to get rid of them.
Removed some warnings and put static imports before non-static imports. Thread and InterruptedException was used and is still used. In the new code you will find use of Thread on line 80 and use of InterruptedException on line 75 right after throws. https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:46: public ActivityTestRule<ConnectActivity> rule = new ActivityTestRule(ConnectActivity.class) { On 2017/01/11 14:34:38, magjed_webrtc wrote: > I think this is causing a new compile warning? Make sure you don't introduce new > warnings. We are trying to get rid of them. To removed warnings I added ConnectActivity as type parameter to the invocation of the ActivityTestRule constructor. Used other definition of LargeTest which is not deprecated.
Removed some warnings and put static imports before non-static imports. Thread and InterruptedException was used and is still used. In the new code you will find use of Thread on line 80 and use of InterruptedException on line 75 right after throws. https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... File webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java (right): https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:46: public ActivityTestRule<ConnectActivity> rule = new ActivityTestRule(ConnectActivity.class) { On 2017/01/11 14:34:38, magjed_webrtc wrote: > I think this is causing a new compile warning? Make sure you don't introduce new > warnings. We are trying to get rid of them. To removed warnings I added ConnectActivity as type parameter to the invocation of the ActivityTestRule constructor. Used other definition of LargeTest which is not deprecated.
On 2017/01/11 16:06:49, mandermo wrote: > Removed some warnings and put static imports before non-static imports. > > Thread and InterruptedException was used and is still used. In the new code you > will find use of Thread on line 80 and use of InterruptedException on line 75 > right after throws. > > https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... > File > webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java > (right): > > https://codereview.webrtc.org/2585813002/diff/140001/webrtc/examples/androidt... > webrtc/examples/androidtests/src/org/appspot/apprtc/test/ConnectActivityStubbedInputOutputTest.java:46: > public ActivityTestRule<ConnectActivity> rule = new > ActivityTestRule(ConnectActivity.class) { > On 2017/01/11 14:34:38, magjed_webrtc wrote: > > I think this is causing a new compile warning? Make sure you don't introduce > new > > warnings. We are trying to get rid of them. > > To removed warnings I added ConnectActivity as type parameter to the invocation > of the ActivityTestRule constructor. Used other definition of LargeTest which is > not deprecated. All classes in the java.lang package are imported by default, so you don't have to add import statements for them. lgtm otherwise
Removed the java.lang imports.
The CQ bit was checked by mandermo@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org, magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2585813002/#ps180001 (title: "Removed unnecessary imports")
The CQ bit was unchecked by mandermo@webrtc.org
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mandermo@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org, kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2585813002/#ps190006 (title: "Merge from master and use of Environment.getExternalStorageDirectory() instead of hardcoded /sdcard…")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 190006, "attempt_start_ts": 1484559386378180,
"parent_rev": "394d460fb53fe742837c8a9bf97328ce6657ba86", "commit_rev":
"a6069e8a0102c97ef50e5aaf63bd3034f3322d5f"}
Message was sent while issue was closed.
Description was changed from ========== Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 ========== to ========== Espresso test case to control loopback call The test case is put inside a new test target. That test target will be started from a test script to asses video quality. BUG=webrtc:6545 Review-Url: https://codereview.webrtc.org/2585813002 Cr-Commit-Position: refs/heads/master@{#16088} Committed: https://chromium.googlesource.com/external/webrtc/+/a6069e8a0102c97ef50e5aaf6... ==========
Message was sent while issue was closed.
Committed patchset #11 (id:190006) as https://chromium.googlesource.com/external/webrtc/+/a6069e8a0102c97ef50e5aaf6...
Message was sent while issue was closed.
https://codereview.webrtc.org/2585813002/diff/190006/webrtc/examples/androidt... File webrtc/examples/androidtests/AndroidManifest.xml (right): https://codereview.webrtc.org/2585813002/diff/190006/webrtc/examples/androidt... webrtc/examples/androidtests/AndroidManifest.xml:15: <uses-permission android:name="android.permissions.RUN_INSTRUMENTATION" /> This is duplicated with line 18. Can you clean up in a follow-up?
Message was sent while issue was closed.
Here is the follow up CL: https://codereview.webrtc.org/2679143002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
