Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2585743002: Move tools/mb -> tools-webrtc/mb (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
3 years, 11 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move tools/mb -> tools-webrtc/mb In addition to moving tools/mb -> tools-webrtc/mb, also move webrtc/build/mb_config.pyl into tools-webrtc/mb to match the default location better. Remove Chromium-specific check for 'mb validate' that failed due to doing this (we never cleaned that when we forked the code). BUG=webrtc:5006 TBR=ehmaldonado@webrtc.org NOTRY=True TESTED=Manually ran: tools-webrtc/mb/mb.py gen -m client.webrtc -b 'iOS64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-iphoneos tools-webrtc/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-mac Review-Url: https://codereview.webrtc.org/2585743002 . Cr-Commit-Position: refs/heads/master@{#15664} Committed: https://chromium.googlesource.com/external/webrtc/+/b2d5577caf90346d03b010822653720fcdfd9596

Patch Set 1 #

Patch Set 2 : Fixed presubmits and tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -3793 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tools-webrtc/mb/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/PRESUBMIT.py View 1 1 chunk +1 line, -5 lines 0 comments Download
A + tools-webrtc/mb/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/docs/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/docs/design_spec.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/docs/user_guide.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/mb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/mb.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/mb.py View 1 3 chunks +3 lines, -27 lines 0 comments Download
A + tools-webrtc/mb/mb_config.pyl View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/mb/mb_unittest.py View 1 4 chunks +2 lines, -59 lines 0 comments Download
D tools/mb/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/mb/PRESUBMIT.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/mb/README.md View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/mb/docs/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/mb/docs/design_spec.md View 1 chunk +0 lines, -426 lines 0 comments Download
D tools/mb/docs/user_guide.md View 1 chunk +0 lines, -297 lines 0 comments Download
D tools/mb/mb View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/mb/mb.bat View 1 chunk +0 lines, -6 lines 0 comments Download
D tools/mb/mb.py View 1 chunk +0 lines, -1571 lines 0 comments Download
D tools/mb/mb_unittest.py View 1 chunk +0 lines, -841 lines 0 comments Download
D webrtc/build/PRESUBMIT.py View 1 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/build/mb_config.pyl View 1 1 chunk +0 lines, -451 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2585743002/20001
4 years ago (2016-12-18 21:06:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11539)
4 years ago (2016-12-18 21:08:56 UTC) #8
kjellander_webrtc
Committed patchset #2 (id:20001) manually as b2d5577caf90346d03b010822653720fcdfd9596 (presubmit successful).
4 years ago (2016-12-18 21:14:46 UTC) #10
ehmaldonado_webrtc
3 years, 11 months ago (2017-01-02 13:47:08 UTC) #11
Message was sent while issue was closed.
On 2016/12/18 21:14:46, kjellander_webrtc wrote:
> Committed patchset #2 (id:20001) manually as
> b2d5577caf90346d03b010822653720fcdfd9596 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698