Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2585273002: Reland of Disabling NOTREACHED which we're hitting flakily in browser tests. (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
Reviewers:
phoglund, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2585183002/ ) Reason for revert: Still hitting NOTREACHED. Original issue's description: > Revert of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2477663002/ ) > > Reason for revert: > To see if the NOTREACHED is still hit. > > Original issue's description: > > Disabling NOTREACHED which we're hitting flakily in browser tests. > > > > I have no idea how bad it is that we're hitting this limit; I'm just > > doing this to stop the tests from flaking. > > > > BUG=webrtc:6484 > > > > Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 > > Cr-Commit-Position: refs/heads/master@{#14974} > > TBR=stefan@webrtc.org,phoglund@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6484 > > Review-Url: https://codereview.webrtc.org/2585183002 > Cr-Commit-Position: refs/heads/master@{#15665} > Committed: https://chromium.googlesource.com/external/webrtc/+/9d7ea0920c2b0a6b6644c99abdf10f415422d563 TBR=stefan@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6484 Review-Url: https://codereview.webrtc.org/2585273002 Cr-Commit-Position: refs/heads/master@{#15676} Committed: https://chromium.googlesource.com/external/webrtc/+/35b41a29b3b039b348460922dbae33992fb88b75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
åsapersson
Created Reland of Disabling NOTREACHED which we're hitting flakily in browser tests.
4 years ago (2016-12-19 13:54:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2585273002/1
4 years ago (2016-12-19 13:54:13 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 13:54:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/35b41a29b3b039b348460922d...

Powered by Google App Engine
This is Rietveld 408576698