Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2583853002: Remove duplicate implementations of string conversion methods. (Closed)

Created:
4 years ago by kthelgason
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove duplicate implementations of string conversion methods. BUG=webrtc:4773 Review-Url: https://codereview.webrtc.org/2583853002 Cr-Commit-Position: refs/heads/master@{#15957} Committed: https://chromium.googlesource.com/external/webrtc/+/c1b661eee00cccbbd2efb4334b3e6f1c05d2173c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M webrtc/sdk/objc/Framework/Classes/helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/testsupport/iosfileutils.mm View 1 chunk +3 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
kthelgason
This CL removes some code that was duplicated in the test helpers. size: small
4 years ago (2016-12-16 10:42:36 UTC) #2
henrika_webrtc
LGTM
4 years ago (2016-12-16 10:47:30 UTC) #3
tkchin_webrtc
On 2016/12/16 10:47:30, henrika_webrtc wrote: > LGTM lgtm
4 years ago (2016-12-19 23:43:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2583853002/1
3 years, 11 months ago (2017-01-04 07:54:19 UTC) #6
commit-bot: I haz the power
Failed to apply patch for webrtc/test/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-04 09:01:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2583853002/20001
3 years, 11 months ago (2017-01-09 08:21:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/14972)
3 years, 11 months ago (2017-01-09 08:47:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2583853002/20001
3 years, 11 months ago (2017-01-09 09:29:41 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:40:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c1b661eee00cccbbd2efb4334...

Powered by Google App Engine
This is Rietveld 408576698