Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2583193002: Removed RTCStatsCollector::ProducePartialResultsOnWorkerThread. (Closed)

Created:
4 years ago by hbos
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed RTCStatsCollector::ProducePartialResultsOnWorkerThread. No stats are collected by it, remove to reduce unnecessary thread hops. BUG=webrtc:6875, chromium:627816 Review-Url: https://codereview.webrtc.org/2583193002 Cr-Commit-Position: refs/heads/master@{#15862} Committed: https://chromium.googlesource.com/external/webrtc/+/f415f8ae73a33bbb965c70d37cbea29cf06903e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -41 lines) Patch
M webrtc/api/rtcstatscollector.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hbos
Please take a look, hta.
4 years ago (2016-12-19 13:50:49 UTC) #4
hta-webrtc
lgtm easy to add back if it turns out we need it.
3 years, 11 months ago (2017-01-02 11:26:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2583193002/1
3 years, 11 months ago (2017-01-02 11:41:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 12:28:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f415f8ae73a33bbb965c70d37...

Powered by Google App Engine
This is Rietveld 408576698