Do not call OnDecoderTiming before timing values are set.

Do not call OnDecoderTiming before timing values are set.

Wait until first frame is decoded to avoid include zeros in stats.

BUG=b/32659204

Review-Url: https://codereview.webrtc.org/2582313002
Cr-Commit-Position: refs/heads/master@{#15752}
Committed: https://chromium.googlesource.com/external/webrtc/+/8d5608880fcede8281fe37a5b10c89c0bb9794f0

[åsapersson, 2016-12-19 08:18:41]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 08:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2016-12-19 08:18:59]

Patchset #1 (id:1) has been deleted

[åsapersson, 2016-12-19 08:20:01]

Description was changed from

==========
Do not call OnDecoderTiming before timing values are set.

Wait until first frame is decoded to avoid include zeros in stats.

BUG=b/32659204
==========

to

==========
Do not call OnDecoderTiming before timing values are set.

Wait until first frame is decoded to avoid include zeros in stats.

BUG=b/32659204
==========

[åsapersson, 2016-12-19 08:20:01]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[commit-bot: I haz the power, 2016-12-19 08:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 08:37:32]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-12-22 08:42:38]

lgtm % nit

https://codereview.webrtc.org/2582313002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/timing.cc (right):

https://codereview.webrtc.org/2582313002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/timing.cc:306: return (num_decoded_frames_ != 0);
> 0

[åsapersson, 2016-12-22 08:49:42]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 08:49:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2016-12-22 08:51:33]

https://codereview.webrtc.org/2582313002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/timing.cc (right):

https://codereview.webrtc.org/2582313002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/timing.cc:306: return (num_decoded_frames_ != 0);
On 2016/12/22 08:42:38, stefan-webrtc (holmer) wrote:
> > 0

Done.

[commit-bot: I haz the power, 2016-12-22 09:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 09:23:44]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2016-12-22 09:24:35]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-12-22 09:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2582313002/#ps40001 (title:
"address comment")

[commit-bot: I haz the power, 2016-12-22 09:24:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 09:26:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482398675322220,
"parent_rev": "c37ad499dac38d992a09e3b3565a366b283a2521", "commit_rev":
"8d5608880fcede8281fe37a5b10c89c0bb9794f0"}

[commit-bot: I haz the power, 2016-12-22 09:26:21]

Description was changed from

==========
Do not call OnDecoderTiming before timing values are set.

Wait until first frame is decoded to avoid include zeros in stats.

BUG=b/32659204
==========

to

==========
Do not call OnDecoderTiming before timing values are set.

Wait until first frame is decoded to avoid include zeros in stats.

BUG=b/32659204

Review-Url: https://codereview.webrtc.org/2582313002
Cr-Commit-Position: refs/heads/master@{#15752}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8d5608880fcede8281fe37a5b...
==========

[commit-bot: I haz the power, 2016-12-22 09:26:22]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/8d5608880fcede8281fe37a5b...