Adding Java and Obj-C bindings for RtpEncodingParameters.ssrc.

Adding Java and Obj-C bindings for RtpEncodingParameters.ssrc.

BUG=webrtc:6903
Review-Url: https://codereview.webrtc.org/2581913002
Cr-Commit-Position: refs/heads/master@{#15936}
Committed: https://chromium.googlesource.com/external/webrtc/+/8014c75931a72a704fa890b884e63a98e9aa8c03

[Taylor Brandstetter, 2016-12-16 02:16:54]

deadbeef@webrtc.org changed reviewers:
+ magjed@webrtc.org, tkchin@webrtc.org

[Taylor Brandstetter, 2016-12-16 02:16:55]

magjed: Can you review Java changes?
tkchin: Can you review Obj-C?

[magjed_webrtc, 2016-12-19 12:35:16]

lgtm

[Taylor Brandstetter, 2017-01-05 01:24:45]

Pinging Zeke for Obj-C code

[tkchin_webrtc, 2017-01-05 22:25:14]

lgtm

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm (right):

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm:35: _ssrc =
[NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
for my own knowledge - is int in C++ 32 or 64 bit?

[Taylor Brandstetter, 2017-01-05 22:47:27]

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm (right):

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm:35: _ssrc =
[NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
On 2017/01/05 22:25:14, tkchin_webrtc wrote:
> for my own knowledge - is int in C++ 32 or 64 bit?

Technically speaking, it's only guaranteed to be 16-bit or larger. Practically
speaking, it's almost exclusively 32-bit.

[tkchin_webrtc, 2017-01-05 23:36:45]

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm (right):

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm:35: _ssrc =
[NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
On 2017/01/05 22:47:27, Taylor Brandstetter wrote:
> On 2017/01/05 22:25:14, tkchin_webrtc wrote:
> > for my own knowledge - is int in C++ 32 or 64 bit?
> 
> Technically speaking, it's only guaranteed to be 16-bit or larger. Practically
> speaking, it's almost exclusively 32-bit.

Ok. I just noticed this is a settable property, as opposed to read-only, so you
may get truncation if someone sets a large number.

[Taylor Brandstetter, 2017-01-06 00:19:07]

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm (right):

https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm:35: _ssrc =
[NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
On 2017/01/05 23:36:45, tkchin_webrtc wrote:
> On 2017/01/05 22:47:27, Taylor Brandstetter wrote:
> > On 2017/01/05 22:25:14, tkchin_webrtc wrote:
> > > for my own knowledge - is int in C++ 32 or 64 bit?
> > 
> > Technically speaking, it's only guaranteed to be 16-bit or larger.
Practically
> > speaking, it's almost exclusively 32-bit.
> 
> Ok. I just noticed this is a settable property, as opposed to read-only, so
you
> may get truncation if someone sets a large number.

Actually, it's not meant to be settable in the first place; fixed.

[tkchin_webrtc, 2017-01-06 01:11:13]

On 2017/01/06 00:19:07, Taylor Brandstetter wrote:
>
https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
> File webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm (right):
> 
>
https://codereview.webrtc.org/2581913002/diff/1/webrtc/sdk/objc/Framework/Cla...
> webrtc/sdk/objc/Framework/Classes/RTCRtpEncodingParameters.mm:35: _ssrc =
> [NSNumber numberWithUnsignedLong:*nativeParameters.ssrc];
> On 2017/01/05 23:36:45, tkchin_webrtc wrote:
> > On 2017/01/05 22:47:27, Taylor Brandstetter wrote:
> > > On 2017/01/05 22:25:14, tkchin_webrtc wrote:
> > > > for my own knowledge - is int in C++ 32 or 64 bit?
> > > 
> > > Technically speaking, it's only guaranteed to be 16-bit or larger.
> Practically
> > > speaking, it's almost exclusively 32-bit.
> > 
> > Ok. I just noticed this is a settable property, as opposed to read-only, so
> you
> > may get truncation if someone sets a large number.
> 
> Actually, it's not meant to be settable in the first place; fixed.

lgtm

[Taylor Brandstetter, 2017-01-06 23:38:41]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-06 23:38:41]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2581913002/#ps20001 (title:
"Make ssrc property readonly.")

[commit-bot: I haz the power, 2017-01-06 23:38:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-07 00:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 00:04:16]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/19834)

[Taylor Brandstetter, 2017-01-07 00:19:22]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-01-07 00:19:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-07 00:53:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483748362381750,
"parent_rev": "055c0a892bd655198bfced3dd9a210bc38ab6c89", "commit_rev":
"8014c75931a72a704fa890b884e63a98e9aa8c03"}

[commit-bot: I haz the power, 2017-01-07 00:53:04]

Description was changed from

==========
Adding Java and Obj-C bindings for RtpEncodingParameters.ssrc.

BUG=webrtc:6903
==========

to

==========
Adding Java and Obj-C bindings for RtpEncodingParameters.ssrc.

BUG=webrtc:6903

Review-Url: https://codereview.webrtc.org/2581913002
Cr-Commit-Position: refs/heads/master@{#15936}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8014c75931a72a704fa890b88...
==========

[commit-bot: I haz the power, 2017-01-07 00:53:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8014c75931a72a704fa890b88...