Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2580963004: Put iOS H264 High profile under a field trial (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Put iOS H264 High profile under a field trial H264 High profile is causing problems for some downstream apps. Therefore, put it behind a field trial instead. BUG=webrtc:6337 Review-Url: https://codereview.webrtc.org/2580963004 Cr-Commit-Position: refs/heads/master@{#15663} Committed: https://chromium.googlesource.com/external/webrtc/+/b4ad603b47f269626585cca717cc53c7e944a8c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc View 2 chunks +38 lines, -24 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
magjed_webrtc
Zeke - please take a look.
4 years ago (2016-12-17 11:33:25 UTC) #12
tkchin_webrtc
On 2016/12/17 11:33:25, magjed_webrtc wrote: > Zeke - please take a look. lgtm thanks for ...
4 years ago (2016-12-18 07:45:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2580963004/20001
4 years ago (2016-12-18 07:48:22 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-18 07:50:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b4ad603b47f269626585cca71...

Powered by Google App Engine
This is Rietveld 408576698