Re-enable Opus complexity tests on Android

Re-enable Opus complexity tests on Android

This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).

The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.

Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.

Finally, a percent label was added to a printout, to match the same
printout in the other test.

BUG=webrtc:6708
Review-Url: https://codereview.webrtc.org/2580383002
Cr-Commit-Position: refs/heads/master@{#15679}
Committed: https://chromium.googlesource.com/external/webrtc/+/8c1dd8d32f72893efc644c5f08f7001fccda9415

[hlundin-webrtc, 2016-12-19 12:51:54]

Description was changed from

==========
Re-enable Opus complexity tests on Android

This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).

The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.

Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.

Finally, a percent label was added to a printout, to match the same
printout in the other test.

BUG=webrtc:6708
==========

to

==========
Re-enable Opus complexity tests on Android

This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).

The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.

Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.

Finally, a percent label was added to a printout, to match the same
printout in the other test.

BUG=webrtc:6708
==========

[hlundin-webrtc, 2016-12-19 12:51:54]

henrik.lundin@webrtc.org changed reviewers:
+ kjellander@webrtc.org, minyue@webrtc.org

[hlundin-webrtc, 2016-12-19 12:54:15]

Please, take a look.

kjellander: webrtc/BUILD.gn
minyue: opus_complexity_unittest.cc

Thanks!

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:27:
webrtc::test::ResourcePath("audio_coding/speech_mono_32_48kHz", "pcm");
This is where the resource file is used.

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:95: 100.0 *
runtime_12500bps / runtime_15500bps, "percent",
This was missing; added now to match line 75.

[kjellander_webrtc, 2016-12-19 13:09:40]

lgtm

[minyue-webrtc, 2016-12-19 13:50:36]

lgtm

nit

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:89: int64_t
runtime_12500bps = RunComplexityTest(config);
still 12500?

[hlundin-webrtc, 2016-12-19 13:53:07]

Change variable name to reflect actual bitrate

[hlundin-webrtc, 2016-12-19 13:54:35]

Change variable name to reflect actual bitrate

[hlundin-webrtc, 2016-12-19 13:54:48]

Patchset #2 (id:20001) has been deleted

[hlundin-webrtc, 2016-12-19 13:55:17]

Thanks! I will commit this updated version.

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
(right):

https://codereview.webrtc.org/2580383002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:89: int64_t
runtime_12500bps = RunComplexityTest(config);
On 2016/12/19 13:50:35, minyue-webrtc wrote:
> still 12500?

No. My bad. Changed the variable name to runtime_10999bps instead.

[hlundin-webrtc, 2016-12-19 13:55:30]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-12-19 13:55:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2580383002/#ps40001 (title:
"Change variable name to reflect actual bitrate")

[commit-bot: I haz the power, 2016-12-19 13:55:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-19 14:18:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482155730461660,
"parent_rev": "fe04bd43cc7a7d45ce59a2a83d716a68d06b5e92", "commit_rev":
"8c1dd8d32f72893efc644c5f08f7001fccda9415"}

[commit-bot: I haz the power, 2016-12-19 14:18:38]

Description was changed from

==========
Re-enable Opus complexity tests on Android

This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).

The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.

Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.

Finally, a percent label was added to a printout, to match the same
printout in the other test.

BUG=webrtc:6708
==========

to

==========
Re-enable Opus complexity tests on Android

This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).

The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.

Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.

Finally, a percent label was added to a printout, to match the same
printout in the other test.

BUG=webrtc:6708

Review-Url: https://codereview.webrtc.org/2580383002
Cr-Commit-Position: refs/heads/master@{#15679}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8c1dd8d32f72893efc644c5f0...
==========

[commit-bot: I haz the power, 2016-12-19 14:18:39]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/8c1dd8d32f72893efc644c5f0...