Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2580343002: Now expect the correct number of streams in EndToEndTest.GetStats. (Closed)

Created:
4 years ago by philipel
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Now expect the correct number of streams in EndToEndTest.GetStats. The rtx streams were not included in the number of expected streams but the test passed most of the time anyway due to how the checking was done. Flake was caused when the number of registered streams jumped passed the number of expected send streams excluding the number of rtx streams. BUG=webrtc:6879 Review-Url: https://codereview.webrtc.org/2580343002 Cr-Commit-Position: refs/heads/master@{#15671} Committed: https://chromium.googlesource.com/external/webrtc/+/20d05a9f71a9c63d8b0d538b983bfa053db76613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
philipel
4 years ago (2016-12-19 11:46:49 UTC) #2
stefan-webrtc
lgtm
4 years ago (2016-12-19 12:12:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2580343002/1
4 years ago (2016-12-19 12:15:54 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 12:17:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/20d05a9f71a9c63d8b0d538b9...

Powered by Google App Engine
This is Rietveld 408576698