Add support for content hints to VideoTrack.

Add support for content hints to VideoTrack.

Permits overriding the source-default is_screencast option to be able to
treat screencast sources as fluid video, preserving motion at the loss
of individual frame quality (or vice versa).

BUG=chromium:653531
R=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2579993003
Cr-Commit-Position: refs/heads/master@{#15659}
Committed: https://chromium.googlesource.com/external/webrtc/+/5214a0ab8e2b622fa7aff888a740e46e80f7ed18

[pbos-webrtc, 2016-12-16 20:56:31]

add thread checkers

[pbos-webrtc, 2016-12-16 20:56:42]

PTAL and let me know which unittests I can offer. :)

[pbos-webrtc, 2016-12-16 20:59:42]

Description was changed from

==========
Add support for content hints to VideoTrack.

Permits overriding the source-default is_screencast option to be able to
treat screencast sources as fluid video, preserving motion at the loss
of individual frame quality.

BUG=chromium:653531
R=deadbeef@webrtc.org
==========

to

==========
Add support for content hints to VideoTrack.

Permits overriding the source-default is_screencast option to be able to
treat screencast sources as fluid video, preserving motion at the loss
of individual frame quality (or vice versa).

BUG=chromium:653531
R=deadbeef@webrtc.org
==========

[Taylor Brandstetter, 2016-12-16 21:27:20]

lgtm

https://codereview.webrtc.org/2579993003/diff/20001/webrtc/api/mediastreamint...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/2579993003/diff/20001/webrtc/api/mediastreamint...
webrtc/api/mediastreaminterface.h:138: // See chromium:653531 and
https://github.com/WICG/mst-content-hint.
nit: Usually we use a crbug link (https://crbug.com/653531)

[Taylor Brandstetter, 2016-12-16 21:32:15]

Oh, not lgtm, forgot about unit tests.

This should have tests in rtpsenderreceiver_unittest.cc that verify the content
hint turns into the correct "is_screencast" flag. And tests in
videotrack_unittest.cc that verify that changing the content hint works, and
fires "OnChanged".

[pbos-webrtc, 2016-12-16 22:56:30]

add unittests to RtpSenderReceiverTest

[pbos-webrtc, 2016-12-16 22:57:29]

I think the tests I added in RtpSenderReceiverTest cover both translation and
propagation of the flag (I trigger it by changing the content hint in
VideoTrack).

[pbos-webrtc, 2016-12-16 22:57:42]

(PTAL :)

[pbos-webrtc, 2016-12-16 22:59:41]

crbug link

[Taylor Brandstetter, 2016-12-16 23:06:38]

lgtm; I agree tests for videotrack.cc are probably overkill.

https://codereview.webrtc.org/2579993003/diff/40001/webrtc/api/rtpsenderrecei...
File webrtc/api/rtpsenderreceiver_unittest.cc (right):

https://codereview.webrtc.org/2579993003/diff/40001/webrtc/api/rtpsenderrecei...
webrtc/api/rtpsenderreceiver_unittest.cc:656: TEST_F(RtpSenderReceiverTest,
PropagatesVideoTrackContentHintForScreencast) {
nit: I'd prefer calling this test
PropagatesVideoTrackContentHintForScreencastSource. Also, a brief comment above
each test summarizing it would be a plus.

[pbos-webrtc, 2016-12-16 23:16:33]

rename test + add comments

[pbos-webrtc, 2016-12-16 23:17:06]

https://codereview.webrtc.org/2579993003/diff/40001/webrtc/api/rtpsenderrecei...
File webrtc/api/rtpsenderreceiver_unittest.cc (right):

https://codereview.webrtc.org/2579993003/diff/40001/webrtc/api/rtpsenderrecei...
webrtc/api/rtpsenderreceiver_unittest.cc:656: TEST_F(RtpSenderReceiverTest,
PropagatesVideoTrackContentHintForScreencast) {
On 2016/12/16 23:06:38, Taylor Brandstetter wrote:
> nit: I'd prefer calling this test
> PropagatesVideoTrackContentHintForScreencastSource. Also, a brief comment
above
> each test summarizing it would be a plus.

Done.

[pbos-webrtc, 2016-12-16 23:17:14]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2016-12-16 23:17:14]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2579993003/#ps80001 (title:
"rename test + add comments")

[commit-bot: I haz the power, 2016-12-16 23:17:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-16 23:39:11]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481930234075410,
"parent_rev": "fb6ad3b1961bde202b3102f8006acd2ce373acd4", "commit_rev":
"5214a0ab8e2b622fa7aff888a740e46e80f7ed18"}

[commit-bot: I haz the power, 2016-12-16 23:39:14]

Description was changed from

==========
Add support for content hints to VideoTrack.

Permits overriding the source-default is_screencast option to be able to
treat screencast sources as fluid video, preserving motion at the loss
of individual frame quality (or vice versa).

BUG=chromium:653531
R=deadbeef@webrtc.org
==========

to

==========
Add support for content hints to VideoTrack.

Permits overriding the source-default is_screencast option to be able to
treat screencast sources as fluid video, preserving motion at the loss
of individual frame quality (or vice versa).

BUG=chromium:653531
R=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2579993003
Cr-Commit-Position: refs/heads/master@{#15659}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5214a0ab8e2b622fa7aff888a...
==========

[commit-bot: I haz the power, 2016-12-16 23:39:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/5214a0ab8e2b622fa7aff888a...