Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2579753002: Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2581663002/ ) Reason for revert: This change broke Chrome too. It's stats processing wants to make a copy of webrtc's stats mapping, which is no longer possible with std::unique_ptr. Original issue's description: > Reland of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2576673002/ ) > > Reason for revert: > Downstream project fixed to not make copies while iterating over the stats mapping. > > Original issue's description: > > Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2567143003/ ) > > > > Reason for revert: > > The change from rtc::linked_ptr to std::unique_ptr broke a downstream project. > > > > Original issue's description: > > > Delete rtc::linked_ptr. Only use, in statstypes.h, replaced with std::unique_ptr. > > > > > > BUG=webrtc:6424 > > > > > > Committed: https://crrev.com/36f74e55792cae19db8b222c29aa38d6e0eb1225 > > > Cr-Commit-Position: refs/heads/master@{#15588} > > > > TBR=solenberg@webrtc.org,pthatcher@webrtc.org,hta@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6424 > > > > Committed: https://crrev.com/8afbc8cba65d99bb7a0feece8fb3055b144106b1 > > Cr-Commit-Position: refs/heads/master@{#15589} > > TBR=solenberg@webrtc.org,pthatcher@webrtc.org,hta@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6424 > > Committed: https://crrev.com/06035cf53abad80b0525f286a3b81e388cc7ee00 > Cr-Commit-Position: refs/heads/master@{#15627} TBR=solenberg@webrtc.org,pthatcher@webrtc.org,hta@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Committed: https://crrev.com/6a58f33450a46370039cd82537612040a91165b3 Cr-Commit-Position: refs/heads/master@{#15629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M webrtc/api/statstypes.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/cryptstring.h View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/linked_ptr.h View 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-webrtc
Created Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr.
4 years ago (2016-12-15 11:54:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2579753002/1
4 years ago (2016-12-15 11:54:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 11:54:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a58f33450a46370039cd82537612040a91165b3 Cr-Commit-Position: refs/heads/master@{#15629}
4 years ago (2016-12-15 11:54:58 UTC) #8
nisse-webrtc
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2641793002/ by nisse@webrtc.org. ...
3 years, 11 months ago (2017-01-18 09:21:44 UTC) #9
the sun
3 years, 11 months ago (2017-01-18 09:45:33 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698