Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2579263002: Don't report packets with id -1 to the transport feedback adapter as they provide no value. (Closed)

Created:
4 years ago by stefan-webrtc
Modified:
4 years ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't report packets with id -1 to the transport feedback adapter as they provide no value. This also avoids an issue where -1 is interpreted as 0xFFFF by the feedback adapter, which in practice likely isn't a problem, but still wrong. BUG=None Review-Url: https://codereview.webrtc.org/2579263002 Cr-Commit-Position: refs/heads/master@{#15647} Committed: https://chromium.googlesource.com/external/webrtc/+/528ec3db0b873b6d4c0e79a848057d33084e5fb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stefan-webrtc
4 years ago (2016-12-16 09:28:02 UTC) #3
philipel
lgtm
4 years ago (2016-12-16 09:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2579263002/1
4 years ago (2016-12-16 09:38:14 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 10:11:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/528ec3db0b873b6d4c0e79a84...

Powered by Google App Engine
This is Rietveld 408576698