Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2578213003: Add UMA stats to bad call detection. (Closed)

Created:
4 years ago by palmkvist
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add UMA stats to bad call detection. Just simple "percentage of call that was bad" stats. BUG=webrtc:6814 Review-Url: https://codereview.webrtc.org/2578213003 Cr-Commit-Position: refs/heads/master@{#16049} Committed: https://chromium.googlesource.com/external/webrtc/+/a40672a120d83d5b244d7284adf79ff975010edd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -2 lines) Patch
M webrtc/video/quality_threshold.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/quality_threshold.cc View 3 chunks +19 lines, -1 line 0 comments Download
M webrtc/video/quality_threshold_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 5 chunks +35 lines, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
palmkvist
Some trouble with the commit queue, so new issue.
4 years ago (2016-12-16 15:34:41 UTC) #10
sprang_webrtc
iirc, lgtm from previous cl åsa ptal
3 years, 11 months ago (2017-01-13 08:52:57 UTC) #17
åsapersson
lgtm
3 years, 11 months ago (2017-01-13 10:51:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578213003/1
3 years, 11 months ago (2017-01-13 11:46:44 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:58:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a40672a120d83d5b244d7284a...

Powered by Google App Engine
This is Rietveld 408576698