Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2578093002: Move tools/valgrind-webrtc -> tools-webrtc/valgrind (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move tools/valgrind-webrtc -> tools-webrtc/valgrind The WebRTC valgrind wrapper scripts needs to be moved in order to unlock us from depending on a Chromium checkout. BUG=webrtc:5006 TBR=ehmaldonado@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2578093002 Cr-Commit-Position: refs/heads/master@{#15662} Committed: https://chromium.googlesource.com/external/webrtc/+/afd5494455f2ca5494780984ede07df15e47998b

Patch Set 1 #

Patch Set 2 : Fixed GN error #

Patch Set 3 : Fix GN again #

Patch Set 4 : Adding the right path to tools/python #

Patch Set 5 : Fix stupid python error #

Patch Set 6 : Sorted presubmit pylint exclusion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1531 lines) Patch
M PRESUBMIT.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/modules_tests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/modules_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/peerconnection_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/rtc_media_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/rtc_media_unittests.gtest-memcheck_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/rtc_pc_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/gtest_exclude/webrtc_nonparallel_tests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/memcheck/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/memcheck/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools-webrtc/valgrind/memcheck/suppressions.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/memcheck/suppressions_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/memcheck/suppressions_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/python-google.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/valgrind.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools-webrtc/valgrind/valgrind-binaries.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools-webrtc/valgrind/valgrind-webrtc.gni View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A + tools-webrtc/valgrind/webrtc_tests.py View 1 2 3 4 1 chunk +5 lines, -6 lines 0 comments Download
A + tools-webrtc/valgrind/webrtc_tests.sh View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/modules_tests.gtest-memcheck.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/peerconnection_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_media_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_media_unittests.gtest-memcheck_mac.txt View 1 chunk +0 lines, -1 line 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_pc_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-memcheck.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/valgrind-webrtc/gtest_exclude/webrtc_nonparallel_tests.gtest-memcheck.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/valgrind-webrtc/memcheck/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D tools/valgrind-webrtc/memcheck/PRESUBMIT.py View 1 chunk +0 lines, -100 lines 0 comments Download
D tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -532 lines 0 comments Download
D tools/valgrind-webrtc/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/valgrind-webrtc/memcheck/suppressions_win32.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/valgrind-webrtc/python-google.gni View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/valgrind-webrtc/valgrind.gni View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/valgrind-webrtc/valgrind-binaries.gni View 1 chunk +0 lines, -425 lines 0 comments Download
D tools/valgrind-webrtc/valgrind-webrtc.gni View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/valgrind-webrtc/webrtc_tests.py View 1 chunk +0 lines, -152 lines 0 comments Download
D tools/valgrind-webrtc/webrtc_tests.sh View 1 chunk +0 lines, -102 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578093002/80001
4 years ago (2016-12-17 20:16:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578093002/100001
4 years ago (2016-12-17 20:18:38 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-17 20:21:45 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/afd5494455f2ca5494780984e...

Powered by Google App Engine
This is Rietveld 408576698