Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2577183004: Add an abstract class for IceTransport (Closed)

Created:
4 years ago by Zhi Huang
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add an abstract class for IceTransport P2PTransportChannl will be renamed to IceTransport and this class will be the base class of IceTransport. By doing this, the Dtls related methods can be separated from the IceTransport. For more detail, https://docs.google.com/document/d/1g9RA0s4RV7hFAcWiAM2b6H5ZohAVpBqcYienEDj6IcY/edit BUG=none Review-Url: https://codereview.webrtc.org/2577183004 Cr-Commit-Position: refs/heads/master@{#15690} Committed: https://chromium.googlesource.com/external/webrtc/+/86abd6f2fdff54c53af7d96e8893bce32eaa71b8

Patch Set 1 : Add abstract class for IceTransport #

Patch Set 2 : Remove protected methods. #

Total comments: 1

Patch Set 3 : Make the comments more clear by adding a link. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/p2p/base/icetransportinternal.h View 1 2 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
Taylor Brandstetter
lgtm https://codereview.webrtc.org/2577183004/diff/120001/webrtc/p2p/base/icetransportinternal.h File webrtc/p2p/base/icetransportinternal.h (right): https://codereview.webrtc.org/2577183004/diff/120001/webrtc/p2p/base/icetransportinternal.h#newcode43 webrtc/p2p/base/icetransportinternal.h:43: // split from this class. Could add a ...
4 years ago (2016-12-19 16:36:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577183004/140001
4 years ago (2016-12-19 19:38:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577183004/140001
4 years ago (2016-12-19 19:49:50 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-19 19:54:09 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/86abd6f2fdff54c53af7d96e8...

Powered by Google App Engine
This is Rietveld 408576698