|
|
Created:
4 years ago by åsapersson Modified:
3 years, 11 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReceiveStatisticsProxy:
- add some unit tests
- change SampleCounter members from int to int64_t
BUG=webrtc:5283
Review-Url: https://codereview.webrtc.org/2577073002
Cr-Commit-Position: refs/heads/master@{#15882}
Committed: https://chromium.googlesource.com/external/webrtc/+/6966bd51fcd5bc9b41a119ff13ae61af444ccb1f
Patch Set 1 #Patch Set 2 #Patch Set 3 : rebase #Patch Set 4 : remove unit tests #Patch Set 5 : add unit tests #
Messages
Total messages: 49 (35 generated)
Description was changed from ========== ReceiveStatisticsProxy: - change SampleCounter members from int to int64_t - add unit tests BUG=none ========== to ========== ReceiveStatisticsProxy: - change SampleCounter members from int to int64_t - add some unit tests BUG=none ==========
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
asapersson@webrtc.org changed reviewers: + sprang@webrtc.org
asapersson@webrtc.org changed reviewers: + stefan@webrtc.org
Does this fix a bug? Maybe add a BUG to it?
Please also update the subject, which currently only says "ReceiveStatisticsProxy:"
lgtm apart from those comments.
Description was changed from ========== ReceiveStatisticsProxy: - change SampleCounter members from int to int64_t - add some unit tests BUG=none ========== to ========== ReceiveStatisticsProxy: - add some unit tests - change SampleCounter members from int to int64_t BUG=webrtc:5283 ==========
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/13629) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17328)
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2577073002/#ps60001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17333) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...) mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/21280)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20534)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20629) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17447)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20631) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...) mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20632) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17451)
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2577073002/#ps110001 (title: "add unit tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 110001, "attempt_start_ts": 1483432912082180, "parent_rev": "ce722b3bb86d6782d777be093622c5ea030bd1d4", "commit_rev": "6966bd51fcd5bc9b41a119ff13ae61af444ccb1f"}
Message was sent while issue was closed.
Description was changed from ========== ReceiveStatisticsProxy: - add some unit tests - change SampleCounter members from int to int64_t BUG=webrtc:5283 ========== to ========== ReceiveStatisticsProxy: - add some unit tests - change SampleCounter members from int to int64_t BUG=webrtc:5283 Review-Url: https://codereview.webrtc.org/2577073002 Cr-Commit-Position: refs/heads/master@{#15882} Committed: https://chromium.googlesource.com/external/webrtc/+/6966bd51fcd5bc9b41a119ff1... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:110001) as https://chromium.googlesource.com/external/webrtc/+/6966bd51fcd5bc9b41a119ff1... |