Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2577073002: ReceiveStatisticsProxy: add some unit tests, change members from int to int64_t. (Closed)

Created:
4 years ago by åsapersson
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ReceiveStatisticsProxy: - add some unit tests - change SampleCounter members from int to int64_t BUG=webrtc:5283 Review-Url: https://codereview.webrtc.org/2577073002 Cr-Commit-Position: refs/heads/master@{#15882} Committed: https://chromium.googlesource.com/external/webrtc/+/6966bd51fcd5bc9b41a119ff13ae61af444ccb1f

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : rebase #

Patch Set 4 : remove unit tests #

Patch Set 5 : add unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -5 lines) Patch
M webrtc/video/receive_statistics_proxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 4 4 chunks +116 lines, -0 lines 0 comments Download

Messages

Total messages: 49 (35 generated)
åsapersson
4 years ago (2016-12-16 09:40:29 UTC) #13
stefan-webrtc
Does this fix a bug? Maybe add a BUG to it?
4 years ago (2016-12-22 09:42:42 UTC) #15
stefan-webrtc
Please also update the subject, which currently only says "ReceiveStatisticsProxy:"
4 years ago (2016-12-22 09:43:02 UTC) #16
stefan-webrtc
lgtm apart from those comments.
4 years ago (2016-12-22 09:43:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577073002/40001
4 years ago (2016-12-22 10:20:51 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/13629) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-12-22 10:23:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577073002/60001
4 years ago (2016-12-22 11:51:07 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17333) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-12-22 11:52:37 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577073002/60001
3 years, 12 months ago (2016-12-23 07:56:46 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20534)
3 years, 12 months ago (2016-12-23 07:59:37 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577073002/60001
3 years, 11 months ago (2017-01-02 07:55:26 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/20629) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-02 07:57:16 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577073002/110001
3 years, 11 months ago (2017-01-03 08:41:58 UTC) #46
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 08:44:10 UTC) #49
Message was sent while issue was closed.
Committed patchset #5 (id:110001) as
https://chromium.googlesource.com/external/webrtc/+/6966bd51fcd5bc9b41a119ff1...

Powered by Google App Engine
This is Rietveld 408576698