Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2576383002: Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time. The spec renamed these recently: https://w3c.github.io/webrtc-stats/#since-21-sep-2016* BUG=chromium:627816 Committed: https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524 Cr-Commit-Position: refs/heads/master@{#15630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/rtcstatscollector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hbos
Please take a sta-- look, hta.
4 years ago (2016-12-15 10:41:41 UTC) #4
hta-webrtc
lgtm
4 years ago (2016-12-15 10:50:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2576383002/1
4 years ago (2016-12-15 14:15:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 14:17:13 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 14:17:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3168c7a04b7b8c65d4871b9ed20d49b6fe95b524
Cr-Commit-Position: refs/heads/master@{#15630}

Powered by Google App Engine
This is Rietveld 408576698