Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2575493002: Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (patchset #1 id:1 of https://codereview.webrtc.org/2566143002/ ) Reason for revert: Downstream import error Original issue's description: > New PeerConnectionInterface::GetStats: No bogus default implementation. > > The Chromium mock implementation implements the new GetStats API, so we > can remove this default implementation. > > BUG=chromium:627816 > > Committed: https://crrev.com/8f2309478da41cd8b829d022874dfd5ddc58551c > Cr-Commit-Position: refs/heads/master@{#15563} TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:627816 Committed: https://crrev.com/e381015ca0c1104edfd0688bcedff29b2e4eae07 Cr-Commit-Position: refs/heads/master@{#15567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hbos
Created Revert of New PeerConnectionInterface::GetStats: No bogus default implementation.
4 years ago (2016-12-13 10:35:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2575493002/1
4 years ago (2016-12-13 10:35:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 10:35:26 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 10:35:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e381015ca0c1104edfd0688bcedff29b2e4eae07
Cr-Commit-Position: refs/heads/master@{#15567}

Powered by Google App Engine
This is Rietveld 408576698