Create VideoReceiver with external VCMTiming object.

Create VideoReceiver with external VCMTiming object.

In order for the VCMTiming object to be correctly updated with decoding timings
when running the WebRTC-NewVideoJitterBuffer experiment the VCMTiming object
has to be available in both the VideoReceiver and the video_coding::FrameBuffer
class. Therefore the VCMTiming object is created in VideoRecieveStream and
then passed to VideoReceiver/video_coding::FrameBuffer as they are constructed.

BUG=webrtc:5514
Committed: https://crrev.com/721d402d71cddc954aa9112f832908b9ead90107
Cr-Commit-Position: refs/heads/master@{#15638}

[philipel, 2016-12-14 12:53:14]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-12-14 13:00:32]

https://codereview.webrtc.org/2575473004/diff/1/webrtc/modules/video_coding/v...
File webrtc/modules/video_coding/video_coding_impl.h (right):

https://codereview.webrtc.org/2575473004/diff/1/webrtc/modules/video_coding/v...
webrtc/modules/video_coding/video_coding_impl.h:153: VCMTiming* timing =
nullptr);
Make this required instead.

[philipel, 2016-12-14 13:21:21]

https://codereview.webrtc.org/2575473004/diff/1/webrtc/modules/video_coding/v...
File webrtc/modules/video_coding/video_coding_impl.h (right):

https://codereview.webrtc.org/2575473004/diff/1/webrtc/modules/video_coding/v...
webrtc/modules/video_coding/video_coding_impl.h:153: VCMTiming* timing =
nullptr);
On 2016/12/14 13:00:32, stefan-webrtc (holmer) wrote:
> Make this required instead.

Done.

[stefan-webrtc, 2016-12-15 14:06:03]

lgtm

https://codereview.webrtc.org/2575473004/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_receiver_unittest.cc (right):

https://codereview.webrtc.org/2575473004/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_receiver_unittest.cc:37: timing_.reset(new
VCMTiming(&clock_));
Maybe move this to the ctor initializer list instead.

[philipel, 2016-12-15 14:17:48]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-12-15 14:17:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[philipel, 2016-12-15 14:18:00]

https://codereview.webrtc.org/2575473004/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_receiver_unittest.cc (right):

https://codereview.webrtc.org/2575473004/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_receiver_unittest.cc:37: timing_.reset(new
VCMTiming(&clock_));
On 2016/12/15 14:06:03, stefan-webrtc (holmer) wrote:
> Maybe move this to the ctor initializer list instead.

I think this is more in style with this piece of code.

[commit-bot: I haz the power, 2016-12-15 15:10:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481811468310570,
"parent_rev": "38dee73156f56b2260a1c9195e0fbee680eaf661", "commit_rev":
"e0eb8779ce5bba87fd2c38212ac36080d82bb723"}

[commit-bot: I haz the power, 2016-12-15 15:11:00]

Description was changed from

==========
Create VideoReceiver with external VCMTiming object.

In order for the VCMTiming object to be correctly updated with decoding timings
when running the WebRTC-NewVideoJitterBuffer experiment the VCMTiming object
has to be available in both the VideoReceiver and the video_coding::FrameBuffer
class. Therefore the VCMTiming object is created in VideoRecieveStream and
then passed to VideoReceiver/video_coding::FrameBuffer as they are constructed.

BUG=webrtc:5514
==========

to

==========
Create VideoReceiver with external VCMTiming object.

In order for the VCMTiming object to be correctly updated with decoding timings
when running the WebRTC-NewVideoJitterBuffer experiment the VCMTiming object
has to be available in both the VideoReceiver and the video_coding::FrameBuffer
class. Therefore the VCMTiming object is created in VideoRecieveStream and
then passed to VideoReceiver/video_coding::FrameBuffer as they are constructed.

BUG=webrtc:5514

Review-Url: https://codereview.webrtc.org/2575473004
==========

[commit-bot: I haz the power, 2016-12-15 15:11:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 15:11:03]

Description was changed from

==========
Create VideoReceiver with external VCMTiming object.

In order for the VCMTiming object to be correctly updated with decoding timings
when running the WebRTC-NewVideoJitterBuffer experiment the VCMTiming object
has to be available in both the VideoReceiver and the video_coding::FrameBuffer
class. Therefore the VCMTiming object is created in VideoRecieveStream and
then passed to VideoReceiver/video_coding::FrameBuffer as they are constructed.

BUG=webrtc:5514

Review-Url: https://codereview.webrtc.org/2575473004
==========

to

==========
Create VideoReceiver with external VCMTiming object.

In order for the VCMTiming object to be correctly updated with decoding timings
when running the WebRTC-NewVideoJitterBuffer experiment the VCMTiming object
has to be available in both the VideoReceiver and the video_coding::FrameBuffer
class. Therefore the VCMTiming object is created in VideoRecieveStream and
then passed to VideoReceiver/video_coding::FrameBuffer as they are constructed.

BUG=webrtc:5514

Committed: https://crrev.com/721d402d71cddc954aa9112f832908b9ead90107
Cr-Commit-Position: refs/heads/master@{#15638}
==========

[commit-bot: I haz the power, 2016-12-15 15:11:04]

Patchset 2 (id:??) landed as
https://crrev.com/721d402d71cddc954aa9112f832908b9ead90107
Cr-Commit-Position: refs/heads/master@{#15638}