Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575073002:
Guard against uninitialized packetization modes. (Closed)
|
Created:
4 years ago by hta-webrtc Modified:
4 years ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGuard against uninitialized packetization modes.
This change inserts a RTC_CHECK for illegal packetization modes
when RTP packetizers are constructed.
This should help find places where this field is not initialized.
BUG=webrtc:6858
Committed: https://crrev.com/88cf05cf73a55d8615dadcefcc7c27bc8f595bc9
Cr-Commit-Position: refs/heads/master@{#15614}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 ========== to ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 ==========
hta@webrtc.org changed reviewers: + kthelgason@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Might as well merge this.
hta@webrtc.org changed reviewers: + stefan@webrtc.org
Adding stefan H for owner approval
I assume the packetization mode can't be set to something weird via sdp so that someone could be evil and trigger this check? LGTM in that case!
On 2016/12/14 20:41:38, stefan-webrtc (holmer) wrote: > I assume the packetization mode can't be set to something weird via sdp so that > someone could be evil and trigger this check? > > LGTM in that case! It's impossible to write type-safe C++ that triggers the bug, since it's an "enum class". One has to go through uninitialized memory to get there. I do worry about whether the C++ compiler might decide that it's impossible to trigger this, and optimize it all out, though :-)
The CQ bit was checked by hta@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481748410187860, "parent_rev":
"547f79461faaadd8f2892ed1e8c8d3fecfe58e94", "commit_rev":
"6fdd23146bbd25c2e998ae1c8aac315d557fd770"}
Message was sent while issue was closed.
Description was changed from ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 ========== to ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 Review-Url: https://codereview.webrtc.org/2575073002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 Review-Url: https://codereview.webrtc.org/2575073002 ========== to ========== Guard against uninitialized packetization modes. This change inserts a RTC_CHECK for illegal packetization modes when RTP packetizers are constructed. This should help find places where this field is not initialized. BUG=webrtc:6858 Committed: https://crrev.com/88cf05cf73a55d8615dadcefcc7c27bc8f595bc9 Cr-Commit-Position: refs/heads/master@{#15614} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/88cf05cf73a55d8615dadcefcc7c27bc8f595bc9 Cr-Commit-Position: refs/heads/master@{#15614} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
