Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2574143002: Run 'git cl format --full' on Base64. (Closed)

Created:
4 years ago by johan
Modified:
4 years ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run 'git cl format --full' on Base64. # Legal requires us to keep the original license header. NOPRESUBMIT=true BUG=None Committed: https://crrev.com/db8af2a9530ea431b0354122ea33addc8f906aed Cr-Commit-Position: refs/heads/master@{#15609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -91 lines) Patch
M webrtc/base/base64.h View 3 chunks +50 lines, -36 lines 0 comments Download
M webrtc/base/base64.cc View 7 chunks +64 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
johan
4 years ago (2016-12-14 12:29:02 UTC) #2
perkj_webrtc
thanks lgtm
4 years ago (2016-12-14 14:29:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2574143002/1
4 years ago (2016-12-14 14:41:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 15:15:16 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 15:15:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8af2a9530ea431b0354122ea33addc8f906aed
Cr-Commit-Position: refs/heads/master@{#15609}

Powered by Google App Engine
This is Rietveld 408576698