Make class of static functions in rtp_to_ntp.h:

Make class of static functions in rtp_to_ntp.h:
- UpdateRtcpList
- RtpToNtp

class RtpToNtpEstimator
- UpdateMeasurements
- Estimate

List with rtcp measurements is now private.

BUG=none

Review-Url: https://codereview.webrtc.org/2574133003
Cr-Commit-Position: refs/heads/master@{#15762}
Committed: https://chromium.googlesource.com/external/webrtc/+/fe50b4d75081c3c0d52c74e97a1b8df57a571b7c

[åsapersson, 2016-12-14 14:15:03]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 14:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 14:16:19]

Dry run: Try jobs failed on following builders:
  android_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[åsapersson, 2016-12-14 14:43:15]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:43:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 15:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:20:28]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2016-12-15 10:07:40]

Patchset #3 (id:40001) has been deleted

[åsapersson, 2016-12-15 10:08:04]

Patchset #3 (id:60001) has been deleted

[åsapersson, 2016-12-15 10:18:13]

Description was changed from

==========
Make class of static functions in rtp_to_ntp.h:
- UpdateRtcpList
- RtpToNtp

class RtpToNtpEstimator
- UpdateMeasurements
- Estimate

List with rtcp measurements is now private.

BUG=none
==========

to

==========
Make class of static functions in rtp_to_ntp.h:
- UpdateRtcpList
- RtpToNtp

class RtpToNtpEstimator
- UpdateMeasurements
- Estimate

List with rtcp measurements is now private.

BUG=none
==========

[åsapersson, 2016-12-15 10:18:13]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-12-19 12:36:07]

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/rtp_to_ntp_estimator.h (right):

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/rtp_to_ntp_estimator.h:54: 
Move these structs to the top of the class.

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/rtp_to_ntp_estimator.h:58: const
std::list<RtcpMeasurement>& measurements() const {
I'd prefer not to expose this. Can we write the tests so that they monitor the
output of Estimate() instead of measurements()?

If it's a lot of work it may not be worth it...

[åsapersson, 2016-12-19 15:06:48]

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/rtp_to_ntp_estimator.h (right):

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/rtp_to_ntp_estimator.h:54: 
On 2016/12/19 12:36:07, stefan-webrtc (holmer) wrote:
> Move these structs to the top of the class.

Done.

https://codereview.webrtc.org/2574133003/diff/80001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/rtp_to_ntp_estimator.h:58: const
std::list<RtcpMeasurement>& measurements() const {
On 2016/12/19 12:36:07, stefan-webrtc (holmer) wrote:
> I'd prefer not to expose this. Can we write the tests so that they monitor the
> output of Estimate() instead of measurements()?
> 
> If it's a lot of work it may not be worth it...

Done.

[åsapersson, 2016-12-19 15:10:31]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 15:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-19 15:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:30:07]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-12-22 09:41:03]

lgtm

[åsapersson, 2016-12-22 10:05:07]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-12-22 10:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 10:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 10:13:22]

Try jobs failed on following builders:
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[åsapersson, 2016-12-22 11:50:23]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-12-22 11:50:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 11:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 11:54:57]

Try jobs failed on following builders:
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)

[åsapersson, 2016-12-22 15:39:43]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-12-22 15:39:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 15:53:51]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482421183449570,
"parent_rev": "bf5f5297c5b49251191bc2c9d76e4468d25beda4", "commit_rev":
"fe50b4d75081c3c0d52c74e97a1b8df57a571b7c"}

[commit-bot: I haz the power, 2016-12-22 15:53:54]

Description was changed from

==========
Make class of static functions in rtp_to_ntp.h:
- UpdateRtcpList
- RtpToNtp

class RtpToNtpEstimator
- UpdateMeasurements
- Estimate

List with rtcp measurements is now private.

BUG=none
==========

to

==========
Make class of static functions in rtp_to_ntp.h:
- UpdateRtcpList
- RtpToNtp

class RtpToNtpEstimator
- UpdateMeasurements
- Estimate

List with rtcp measurements is now private.

BUG=none

Review-Url: https://codereview.webrtc.org/2574133003
Cr-Commit-Position: refs/heads/master@{#15762}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fe50b4d75081c3c0d52c74e97...
==========

[commit-bot: I haz the power, 2016-12-22 15:53:55]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/fe50b4d75081c3c0d52c74e97...