Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2574123002: Revert of Delete VideoFrame default constructor, and IsZeroSize method. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ ) Reason for revert: Crashes perf tests, e.g., ./out/Debug/webrtc_perf_tests --gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet' dies with an assert related to rtc::Optional. Original issue's description: > Delete VideoFrame default constructor, and IsZeroSize method. > > This ensures that the video_frame_buffer method never can return a > null pointer. > > BUG=webrtc:6591 > > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997 > Cr-Commit-Position: refs/heads/master@{#15574} TBR=magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6591 Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23 Cr-Commit-Position: refs/heads/master@{#15597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -87 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 2 chunks +9 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/include/i420.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 8 chunks +10 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/frame_generator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 6 chunks +22 lines, -34 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_frame.h View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nisse-webrtc
Created Revert of Delete VideoFrame default constructor, and IsZeroSize method.
4 years ago (2016-12-14 10:06:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2574123002/1
4 years ago (2016-12-14 10:06:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 10:06:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23 Cr-Commit-Position: refs/heads/master@{#15597}
4 years ago (2016-12-14 10:06:55 UTC) #8
nisse-webrtc
4 years ago (2016-12-14 13:16:45 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2574183002/ by nisse@webrtc.org.

The reason for reverting is: Fixing perf tests..

Powered by Google App Engine
This is Rietveld 408576698